1516354 - wrong button color in install add-on doorhanger

Status: RESOLVED WORKSFORME

(Toolkit :: Themes, defect, P5)

Comment 1

[Sören Hentzschel]

(sorry for submitting too early, my cat walked over my keyboard ;-) )

The doorhanger for installing an add-on has a wrong button color for the install button before it becomes blue. I will attach a screenshot which shows the difference between Firefox 65 Beta and Firefox 66 Nightly.

Comment 2

[Sören Hentzschel]

Attachment: screenshot

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

Happy to take a patch in Nightly or even in 66 early beta.

Comment 4

[Dão Gottwald [:dao]]

I'm having trouble getting into the state where the install button is initially disabled. Sören, do you have reliable steps?

Must have something to do with these checks:

https://searchfox.org/mozilla-central/rev/358f816f63da072145c593e9e2ac36b7250ecd25/browser/base/content/browser-addons.js#560-561

https://searchfox.org/mozilla-central/rev/358f816f63da072145c593e9e2ac36b7250ecd25/browser/base/content/browser-addons.js#451-454

Maybe my current internet connection is too fast.

Comment 5

[Sören Hentzschel]

Sorry, I forgot this old needinfo request. It's still an issue in Firefox 88 and easy to reproduce with larger add-on files, like the Bergamot extension (https://github.com/mozilla-extensions/bergamot-browser-extension/releases/tag/v0.3.0).

But this won't be any longer an issue with the Proton redesign, so closing as WORKSFORME.