1516673 - Support cbcs scheme in gmp-clearkey

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

We should support cbcs in our clearkey impl to improve our test coverage.

Comment 1

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

I spoke to :jcj about doing this with some of our existing crypto libs:

you’ll be working with the higher-level PK11_Encrypt / PK11_Decrypt functions (included via nss.h) . https://searchfox.org/mozilla-central/source/netwerk/srtp/src/crypto/cipher/aes_gcm_nss.c#284 might be a useful general reference about how to set things up and call — while it’s using GCM instead of CTR or CBC, at broad strokes it’s a decent enough pattern

It's not in stone we'd want to go this route, but it would be nice to leverage existing works for clearkey if we can. We may also wish to consider replacing some of the existing clearkey cenc machinery if possible.

Comment 2

[Jason Burton]

Attachment: Bug 1516673 - Adds CBCS encryption scheme functionality. r=bryce

Comment 3

[Jason Burton]

Attachment: Bug 1516673 - Remove PK11_Finalize to nss exported symbols. r=keeler

Add PK11_Finalize to nss exported symbols so that it can be used outside of the
nss lib. Without this, attempts to use PK11_Finalize will result in linker
errors.

Comment 4

[Jason Burton]

Attachment: Bug 1516673 - Include code changes from reviewer comment. r=bryce

Depends on D60053

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e1f08362eb0
Adds CBCS encryption scheme functionality. r=bryce

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/2e1f08362eb0