Closed Bug 1516673 Opened 2 years ago Closed 5 months ago

Support cbcs scheme in gmp-clearkey

Categories

(Core :: Audio/Video: Playback, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla76
Tracking Status
firefox76 --- fixed

People

(Reporter: bryce, Assigned: burtonljas)

References

(Blocks 4 open bugs)

Details

Attachments

(1 file, 2 obsolete files)

We should support cbcs in our clearkey impl to improve our test coverage.

I spoke to :jcj about doing this with some of our existing crypto libs:

you’ll be working with the higher-level PK11_Encrypt / PK11_Decrypt functions (included via nss.h) . https://searchfox.org/mozilla-central/source/netwerk/srtp/src/crypto/cipher/aes_gcm_nss.c#284 might be a useful general reference about how to set things up and call — while it’s using GCM instead of CTR or CBC, at broad strokes it’s a decent enough pattern

It's not in stone we'd want to go this route, but it would be nice to leverage existing works for clearkey if we can. We may also wish to consider replacing some of the existing clearkey cenc machinery if possible.

Assignee: bvandyk → burtonljas

Add PK11_Finalize to nss exported symbols so that it can be used outside of the
nss lib. Without this, attempts to use PK11_Finalize will result in linker
errors.

Attachment #9132622 - Attachment description: Bug 1516673 - Add PK11_Finalize to nss exported symbols. → Bug 1516673 - Add PK11_Finalize to nss exported symbols. r=keeler
Attachment #9121133 - Attachment description: Bug 1516673 - Added pattern vars and code for assignment pattern data → Bug 1516673 - Add support for CBCS scheme. r=bryce

Depends on D60053

Attachment #9132622 - Attachment description: Bug 1516673 - Add PK11_Finalize to nss exported symbols. r=keeler → Bug 1516673 - Remove PK11_Finalize to nss exported symbols. r=keeler
Attachment #9121133 - Attachment description: Bug 1516673 - Add support for CBCS scheme. r=bryce → Bug 1516673 - Add unique_ptr types. r=bryce
Attachment #9132990 - Attachment is obsolete: true
Attachment #9132622 - Attachment is obsolete: true
Attachment #9121133 - Attachment description: Bug 1516673 - Add unique_ptr types. r=bryce → Bug 1516673 - Adds CBCS encryptions scheme functionality. r=bryce
Attachment #9121133 - Attachment description: Bug 1516673 - Adds CBCS encryptions scheme functionality. r=bryce → Bug 1516673 - Adds CBCS encryption scheme functionality. r=bryce
Pushed by aiakab@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2e1f08362eb0
Adds CBCS encryption scheme functionality. r=bryce
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in before you can comment on or make changes to this bug.