1516770 - Legacy add-ons "Find replacement" button has wrong text color

Status: VERIFIED FIXED

(Toolkit :: Themes, defect, P3)

Description

[Tim Nguyen :ntim]

Attachment: legacy addon find replacement.PNG

Similar to bug 1509629, but less visible as this page rarely appears (it still does as of today though)

Comment 1

[Tim Nguyen :ntim]

Dão, can you please look into this ?

Comment 2

[Tim Nguyen :ntim]

In case it helps, here's the relevant code:

https://searchfox.org/mozilla-central/rev/fc229ed2c78648e402a9bbd50d99b69d0e227844/toolkit/mozapps/extensions/content/extensions.xml#680
https://searchfox.org/mozilla-central/rev/fc229ed2c78648e402a9bbd50d99b69d0e227844/toolkit/themes/shared/extensions/extensions.inc.css#958-973

Comment 3

[Dão Gottwald [:dao]]

Attachment: Bug 1516770 - Drop custom styling for "Find replacement" button for legacy addons. r=aswan

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/636318254d8f
Drop custom styling for "Find replacement" button for legacy addons. r=aswan

Comment 5

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/636318254d8f

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 9034663 [details]
Bug 1516770 - Drop custom styling for "Find replacement" button for legacy addons. r=aswan

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: bug 1473922

User impact if declined: see comment 0

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: No

If yes, steps to reproduce:

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): trivial fix

String changes made/needed:

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9034663 [details]
Bug 1516770 - Drop custom styling for "Find replacement" button for legacy addons. r=aswan

[Triage Comment]
Minor CSS fix-up. Approved for 65.0b10.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/96ac45c9342e

Comment 9

[Cristian Baica [:cbaica], Release Desktop QA]

I cannot reproduce the issue, due to the fact that I cannot install a deprecated legacy addon in Fx65 or Fx66.

• I have tried to install "website_city_country_info-1.0.1.4-fx" (which is a legacy addon) in Fx 53 and then update Fx to the latest version, but the addon is removed after the update.
• I have also tried to open the profile created in Fx53 with the addon installed in Fx66, but the addon does not show up in the extension list.

Could you please provide a legacy addon with which to test this issue and maybe a way to force install it in Fx66/Fx65?
Either that or in a worst case scenario confirm that the Fix was applied in Fx65.0b10?

Comment 10

[Andrew Swan [:aswan]]

(In reply to Cristian Baica [:cbaica], Release Desktop QA from comment #9)

• I have tried to install "website_city_country_info-1.0.1.4-fx" (which is a legacy addon) in Fx 53 and then update Fx to the latest version, but the addon is removed after the update.

I'm not familiar with website_city_country_info but that should not happen, the extension should appear in the "Legacy Extensions" pane of about:addons, instead of the "Extensions" pane.

In any case, I have a profile with a legacy extension installed and I can confirm that this is fixed in the 2019-01-12 Nightly.

Comment 11

[Cristian Baica [:cbaica], Release Desktop QA]

If it's not too much to ask, could you also verify the fix on the latest beta build? Just so we can set the appropriate flags for that branch as well.

Comment 12

[Andrew Swan [:aswan]]

Sorry this fell through the cracks. I don't have a profile handy for testing this but given thatn 65 is already on release, I assume even if we found a problem there, we wouldn't bother to uplift a fix.