Closed Bug 1517016 Opened Last year Closed 10 months ago

Fix l10n for picking up new SM branding location

Categories

(SeaMonkey :: Build Config, enhancement)

enhancement
Not set

Tracking

(seamonkey2.49esr unaffected, seamonkey2.53 affected, seamonkey2.57esr fixed, seamonkey2.63 wontfix)

RESOLVED FIXED
seamonkey2.64
Tracking Status
seamonkey2.49esr --- unaffected
seamonkey2.53 --- affected
seamonkey2.57esr --- fixed
seamonkey2.63 --- wontfix

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

References

Details

Attachments

(1 file)

At the moment l10n does not know where the SM branding is so files are missing from gecko-strings repo.
Assignee: nobody → iann_bugzilla
Add suite/branding/seamonkey to relevant files as per TB version (Bug 1434667)
Attachment #9033782 - Flags: review?(frgrahl)
Something is wrong here with the merge. Need to look at it when I have more time.

> suite
>   branding/seamonkey
>     brand.dtd
>         // add and localize this file
>     brand.properties
>         // add and localize this file
>   chrome
>     branding
>       brand.dtd
>           // remove this file
>       brand.properties
>           // remove this file
>     common
Comment on attachment 9033782 [details] [diff] [review]
Update l10n files

Review of attachment 9033782 [details] [diff] [review]:
-----------------------------------------------------------------

I basically goofed. Forgot about Bug 1451847 Part 3 for the branding and Bug 1378089 for the bookmarks shuffle around. So when the script removed the old files it was technically correct. 

We have imho 2 options:

1.) Wait for localizers to pick up the change (branding was onyl really used a little in de and ru) 
2.) Restore the removed files in a local copy, change the location to the correct one and push them to the l10n repos. 

Bookmarks would need additional changes and branding was mostly untranslated anyway so not sure if we should pursue this.
Attachment #9033782 - Flags: review?(frgrahl) → review-
Comment on attachment 9033782 [details] [diff] [review]
Update l10n files

From r- to r+ in a single move. Sorry this is essentially right :)

Also needed for 2.57.
Attachment #9033782 - Flags: review-
Attachment #9033782 - Flags: review+
Attachment #9033782 - Flags: approval-comm-esr60?

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/e267cc10e397
Fix l10n for picking up new SeaMonkey branding location. r=frg

Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.64
Comment on attachment 9033782 [details] [diff] [review]
Update l10n files

a=me
Attachment #9033782 - Flags: approval-comm-esr60? → approval-comm-esr60+
You need to log in before you can comment on or make changes to this bug.