Closed
Bug 1558802
Opened 6 years ago
Closed 6 years ago
Branding files not reported as missing on l10n dashboard
Categories
(SeaMonkey :: Build Config, defect)
SeaMonkey
Build Config
Tracking
(seamonkey2.49esr unaffected, seamonkey2.53+ fixed, seamonkey2.57esr+ fixed, seamonkey2.63 wontfix)
RESOLVED
FIXED
seamonkey2.66
People
(Reporter: flod, Assigned: iannbugzilla)
References
Details
Attachments
(1 file)
|
997 bytes,
patch
|
flod
:
review+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
Branding files are not reported as missing, because there's no mention of the branding folder in filter.py, only in l10n.ini and l10n.toml
https://hg.mozilla.org/comm-central/file/f6f0c189c55a7e2d1acf453c220da679b2e17dae/suite/locales/filter.py#l8
Added relevant directory to filter.py
Thanks for the pointer
Attachment #9071681 -
Flags: review?(francesco.lodolo)
Attachment #9071681 -
Flags: approval-comm-esr60?
|
Reporter | |
Comment 2•6 years ago
|
||
Comment on attachment 9071681 [details] [diff] [review]
Add to filter.py
Review of attachment 9071681 [details] [diff] [review]:
-----------------------------------------------------------------
Looks correct to me. Hopefully pike will yell if that's not the case.
Attachment #9071681 -
Flags: review?(francesco.lodolo) → review+
|
||
Updated•6 years ago
|
Attachment #9071681 -
Flags: approval-comm-esr60? → approval-comm-esr60+
Keywords: checkin-needed
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/4c8023a16017
Branding files not reported as missing on l10n dashboard. r=flod
|
|
||
Comment 4•6 years ago
|
||
status-seamonkey2.53:
--- → affected
status-seamonkey2.57esr:
--- → fixed
status-seamonkey2.63:
--- → wontfix
tracking-seamonkey2.53:
--- → ?
tracking-seamonkey2.57esr:
--- → +
Target Milestone: --- → seamonkey2.66
|
|
||
Comment 5•5 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•