Closed Bug 1558802 Opened 1 year ago Closed 1 year ago

Branding files not reported as missing on l10n dashboard

Categories

(SeaMonkey :: Build Config, defect)

defect
Not set
normal

Tracking

(seamonkey2.49esr unaffected, seamonkey2.53+ fixed, seamonkey2.57esr+ fixed, seamonkey2.63 wontfix)

RESOLVED FIXED
seamonkey2.66
Tracking Status
seamonkey2.49esr --- unaffected
seamonkey2.53 + fixed
seamonkey2.57esr + fixed
seamonkey2.63 --- wontfix

People

(Reporter: flod, Assigned: iann_bugzilla)

References

Details

Attachments

(1 file)

Branding files are not reported as missing, because there's no mention of the branding folder in filter.py, only in l10n.ini and l10n.toml
https://hg.mozilla.org/comm-central/file/f6f0c189c55a7e2d1acf453c220da679b2e17dae/suite/locales/filter.py#l8

Assignee: nobody → iann_bugzilla
Status: NEW → ASSIGNED
Attached patch Add to filter.pySplinter Review

Added relevant directory to filter.py

Thanks for the pointer

Attachment #9071681 - Flags: review?(francesco.lodolo)
Attachment #9071681 - Flags: approval-comm-esr60?
Comment on attachment 9071681 [details] [diff] [review]
Add to filter.py

Review of attachment 9071681 [details] [diff] [review]:
-----------------------------------------------------------------

Looks correct to me. Hopefully pike will yell if that's not the case.
Attachment #9071681 - Flags: review?(francesco.lodolo) → review+
Attachment #9071681 - Flags: approval-comm-esr60? → approval-comm-esr60+
Keywords: checkin-needed

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/4c8023a16017
Branding files not reported as missing on l10n dashboard. r=flod

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.