1517088 - Rename extensionSupport.jsm to ExtensionSupport.jsm

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, enhancement)

Description

[Geoff Lankow (:darktrojan)]

This file has the wrong name. If it had an uppercase E, things would be easier.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1517088-extension-support-1.diff

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 9033879 [details] [diff] [review]
1517088-extension-support-1.diff

Hmm, this patch really upsets "Splinter Review". No trace of the new ExtensionSupport.jsm and I see:
  common/src/extensionSupport.jsm copied from common/src/extensionSupport.jsm
Yeah, right :-(

Other than that, a commit message might come in handy.

Comment 3

[Geoff Lankow (:darktrojan)]

(In reply to Jorg K (GMT+1) (urgent reviews and bustage fix only, Dec 22nd to Jan 1st) from comment #2)
> Hmm, this patch really upsets "Splinter Review". No trace of the new
> ExtensionSupport.jsm and I see:
>   common/src/extensionSupport.jsm copied from common/src/extensionSupport.jsm
> Yeah, right :-(

Quality. The diff page doesn't mention it at all.

> Other than that, a commit message might come in handy.

Oh right, I remember thinking I need to do it, but I was in the middle of something else at the time.

Comment 4

[Jorg K (CEST = GMT+2)]

I was going to add the commit message for you, but I'll leave it to you to make this apply:

$ hg qpush
applying 1517088-extension-support-1.diff
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh 1517088-extension-support-1.diff

It doesn't even say what it doesn't like :-(

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3104defb8252
Rename extensionSupport.jsm to ExtensionSupport.jsm; r=jorgk DONTBUILD

Comment 6

[Geoff Lankow (:darktrojan)]

As we established on IRC, the case-insensitive Windows filesystem can't handle having an extensionsSupport.jsm and an ExtensionsSupport.jsm, so I dropped the former with the deprecation warning. No major loss.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8b3e27530e40
Rename extensionSupport.jsm to ExtensionSupport.jsm, missed test files; rs-bustage-fix

Comment 8

[Geoff Lankow (:darktrojan)]

Attachment: 1517088-extension-support-2.diff

Here, you can rubber-stamp these test files I missed because I am blind. I've increased the mozmill and jsbridge version numbers too, because bug 1516843 makes that necessary when altering those extensions.

Comment 9

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/acd8971f3d750f454a4a35630782d9d33782d18d
Update required jsbridge version number; rs=bustage-fix

Comment 10

[:aceman]

Maybe those mozmill and jsbridge could be changed in a different way, e.g. like 1.5.16A or 1.5.16.1 because there exists a real 1.5.17 version of mozmill upstream and is not the same as ours.

Comment 11

[Geoff Lankow (:darktrojan)]

Perhaps we should rename both packages.