Closed
Bug 151718
Opened 22 years ago
Closed 22 years ago
no dimensions for site icon (favicon) at mozilla.org
Categories
(SeaMonkey :: Page Info, defect)
SeaMonkey
Page Info
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: aha, Assigned: db48x)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
1.52 KB,
patch
|
deanis74
:
review+
bzbarsky
:
superreview+
roc
:
approval+
|
Details | Diff | Splinter Review |
Repro: 1. open http://www.mozilla.org/ (or any with favicon) 2. open Page Info | Media 3. select site icon Actual: Dimensions are Width: px and Height: px Expected: Real dimensions or display 'Unknown' instead actual 'Width: px Height: px' 2002061308/trunk/W2K
Assignee | ||
Comment 1•22 years ago
|
||
Pretty sure this is a dup. The acutal problem is in the DOM, the width/height aren't exposed for this particular type of image.
Severity: normal → minor
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 2000 → All
Hardware: PC → All
Whiteboard: dupme
Reporter | ||
Comment 2•22 years ago
|
||
In bug 124454 in 4th comment ( http://bugzilla.mozilla.org/show_bug.cgi?id=124454#c4 ) Neil Marshall noted it, but bug description looks different - it's about displaying image, not about image sizes. Also bug 122125 is related - real dimensions of images, but I don't think, that isn't real dupe, rather this bug depends on it, because both IMHO need same backend.
Assignee | ||
Comment 3•22 years ago
|
||
ok, I found a trick that fixed this, yay.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 4•22 years ago
|
||
Daniel, but with actual nightbuild shortcut icon is not listed in Media tab.
Whiteboard: dupme
Assignee | ||
Comment 5•22 years ago
|
||
errr
Assignee | ||
Comment 6•22 years ago
|
||
yea, I'm just dumb
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 7•22 years ago
|
||
not to mention lax testing on my part :P
![]() |
||
Comment 8•22 years ago
|
||
// should this test use regexes to be a little more lenient wrt whitespace? Move that comment to where it's relevant and sr=bzbarsky
Assignee | ||
Comment 9•22 years ago
|
||
Attachment #104323 -
Attachment is obsolete: true
![]() |
||
Comment 10•22 years ago
|
||
Comment on attachment 104339 [details] [diff] [review] comment moved as seen on TV
Attachment #104339 -
Flags: superreview+
Comment 11•22 years ago
|
||
Comment on attachment 104339 [details] [diff] [review] comment moved simple enough. r=me
Attachment #104339 -
Flags: review+
Comment on attachment 104339 [details] [diff] [review] comment moved a=roc+moz for trunk
Attachment #104339 -
Flags: approval+
Assignee | ||
Comment 13•22 years ago
|
||
bz checked this in last night.
Status: REOPENED → RESOLVED
Closed: 22 years ago → 22 years ago
Resolution: --- → FIXED
Comment 14•22 years ago
|
||
Is the favicon purposely not listed in the Media tab on the trunk?
Assignee | ||
Comment 15•22 years ago
|
||
they should be listed now that the patch is in
Assignee | ||
Comment 16•22 years ago
|
||
I just upgraded, and favicons show up in the list just fine.
Comment 17•22 years ago
|
||
Linux 2002103010, they're not there. They're in the Link tab. Not in Media. Patch should be in this build.
Assignee | ||
Comment 18•22 years ago
|
||
yea, it should be there. what's on line 505 of your pageinfo.js? (chrome://navigator/content/pageInfo.js)
Comment 19•22 years ago
|
||
Odd, isn't this the pre-patch code? http://lxr.mozilla.org/seamonkey/source/xpfe/browser/resources/content/pageInfo.js#505 Bonsai says the patch was applied, but lxr doesn't reflect it. http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/xpfe/browser/resources/content&command=DIFF_FRAMESET&file=pageInfo.js&rev1=1.42&rev2=1.43&root=/cvsroot
Reporter | ||
Comment 20•22 years ago
|
||
It's good, but not perfect: When you firstly open Media tab using 2002103008/trunk/W2K on http://www.mozilla.org, both dimensions for mozilla-16.png are 0px. When you switch to mozilla-banner.gif and back to mozilla-16.png, dimensions are correct - 16px both. BTW there are several ways to call shortcut icon, but only one is supported by Page Info: <link REL="icon" HREF="images/mozilla-16.png" TYPE="image/png"> For example, this case is not actually supported by PageInfo: <link REL="SHORTCUT ICON" HREF="images/mozilla-16.png" TYPE="image/png"> -> REOPEN
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 21•22 years ago
|
||
lxr is broken. supporting "shortcut icon" is bug 177047, and should go in tommorrow or the next day.
Status: REOPENED → RESOLVED
Closed: 22 years ago → 22 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 22•22 years ago
|
||
Daniel: thanx for pointing to bug 177047, but what about 0px problem?
Assignee | ||
Comment 23•22 years ago
|
||
what site are you seeing this on?
Reporter | ||
Comment 24•22 years ago
|
||
Again: It's good, but not perfect: When you firstly open Media tab using 2002103008/trunk/W2K on http://www.mozilla.org, both dimensions for ^^^^^^^^^^^^^^^^^^^^^^ mozilla-16.png are 0px. When you switch to mozilla-banner.gif and back to mozilla-16.png, dimensions are correct - 16px both.
Assignee | ||
Comment 25•22 years ago
|
||
dunno man. I just now downloaded 2002103110 and it works fine. are there any js errors?
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•