1517247 - Can't submit the patch for bug 1517241 via phabricator as it touches hundreds of files

Status: REOPENED

(Conduit :: moz-phab, enhancement, P3)

Description

[Emilio Cobos Álvarez [:emilio]]

Trying to submit the patch for bug 1517241 via phabricator errors:

$ arc diff HEAD~                                                                                                                                                                                                
Linting...
No lint engine configured for this project.
Running unit tests...
No unit test engine is configured for this project.
Using git cinnabar to get the base commit.
 Exception 
[HTTP/500] Internal Server Error
As received by the server, this request had a nonzero content length but no POST data.

Normally, this indicates that it exceeds the 'post_max_size' setting in the PHP configuration on the server. Increase the 'post_max_size' setting or reduce the size of the request.

Request size according to 'Content-Length' was '40029005', 'post_max_size' is set to '32M'.
(Run with `--trace` for a full exception trace.)

Comment 2

[:glob ✱]

reopening: what happened here is different from bug 1492214, and it's something we may be able to work around.

the diff itself is small; 1.75MB as a patch.  however arc ballooned this out to ~39MB, which is too large to be accepted by our phabricator install.

what happened is this patch touches 953 files.  in order to support expanding the context of within the phabricator ui, arc submits the full content of each file modified.

once we switch off wrapping arc, moz-phab could detect massive full-context payloads and offer to submit a patch with fewer lines of context.

Comment 3

[Steven MacLeod [:smacleod]]

(In reply to Byron Jones ‹:glob› 🎈 from comment #2)

once we switch off wrapping arc, moz-phab could detect massive full-context
payloads and offer to submit a patch with fewer lines of context.

:emilio, as a workaround since you're using arc directly, you can pass --less-context when calling arc diff (arc diff --less-context) and it will send the much smaller diff. Your reviewers won't be able to expand context on the diffs though.