1517523 - [de-xbl] Migrate results-message to custom element.

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, task)

Description

[Arshad Khan [:arshad]]

Binding Link - https://searchfox.org/comm-central/source/mail/base/content/glodaFacetBindings.xml#1166

Comment 1

[Arshad Khan [:arshad]]

Attachment: results-message.patch

Hey Magnus,

This patch appears to successfully render results but somehow it messes up the facet visualization. I get `this.mm is null` where this.mm is 
 asssigned docshell.messageManager. Could you please take a look at this and let me know which part of the patch is messing up things
?

Comment 2

[Magnus Melin [:mkmelin]]

The this.mm problem seems to be because of some bug in objectTreeAsString
If I temporarily remove that, I get the real problem

rules is undefined glodaFacetVis.js:176
render chrome://messenger/content/glodaFacetVis.js:176
build chrome://messenger/content/glodaFacetVis.js:28
buildFunc chrome://messenger/content/glodaFacet.js:53
facetingCompleted chrome://messenger/content/glodaFacetView.js:585
_drive resource:///modules/gloda/facet.js:107
FacetDriver_go resource:///modules/gloda/facet.js:80
build chrome://messenger/content/glodaFacetView.js:530
initialBuild chrome://messenger/content/glodaFacetView.js:493
onQueryCompleted chrome://messenger/content/glodaFacetView.js:963
GlodaMsgSearcher_onQueryCompleted resource:///modules/gloda/msg_search.js:339
gloda_coll_onQueryCompleted resource:///modules/gloda/collection.js:626
onQueryCompleted resource:///modules/gloda/datastore.js:149
gloda_coll_onQueryCompleted resource:///modules/gloda/collection.js:626
onQueryCompleted resource:///modules/gloda/datastore.js:149
gloda_coll_onQueryCompleted resource:///modules/gloda/collection.js:626
onQueryCompleted resource:///modules/gloda/datastore.js:149
gloda_coll_onQueryCompleted resource:///modules/gloda/collection.js:626
onQueryCompleted resource:///modules/gloda/datastore.js:149
gloda_ds_qfq_handleCompletion resource:///modules/gloda/datastore.js:390

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: results-message.patch

Unbitrotted and with the temporary uncommenting. You should be able to get on with this bug now

Comment 4

[Magnus Melin [:mkmelin]]

Oh, the unbitrotted patch also need to remove glodaFacetBindings.xml

Comment 5

[Magnus Melin [:mkmelin]]

Attachment: results-message.patch

Now with the lodaFacetBindings.xml file removed

Comment 6

[Arshad Khan [:arshad]]

Attachment: results-message.patch

Comment 7

[Arshad Khan [:arshad]]

Attachment: results-message.patch

Comment 8

[Magnus Melin [:mkmelin]]

Comment on attachment 9045675 [details] [diff] [review]
results-message.patch

Review of attachment 9045675 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin with some nits fixed

Also run it past try before setting checkin-needed

::: mail/base/content/glodaFacet.js
@@ +64,5 @@
>    }
>  }
>  
> +/**
> + * MozResultsMessage shows up the search results for the string entered in gloda-searchbox.

remove the "up"

@@ +223,2 @@
>  customElements.define("facet-date", MozFacetDate);
> +customElements.define("facet-results-message", MozResultsMessage);

Please make the class name MozFacetResultsMessage

Comment 9

[Arshad Khan [:arshad]]

Attachment: results-message.patch

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=310a09bfa29aae5eef6cb24e701d1d5dee106b4a

Comment 10

[Arshad Khan [:arshad]]

Attachment: results-message.patch

Comment 11

[Arshad Khan [:arshad]]

Removed empty gldaFacetBindings.css file.

Comment 12

[Arshad Khan [:arshad]]

(In reply to Arshad Khan [:arshad] from comment #9)

Created attachment 9045901 [details] [diff] [review]
results-message.patch

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=310a09bfa29aae5eef6cb24e701d1d5dee106b4a

I need to rebase the patch, but I am not sure whether trunk is failing or not.

Comment 13

[Magnus Melin [:mkmelin]]

You just need to rebase, trunk is fine atm.

Comment 14

[Arshad Khan [:arshad]]

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=59ecb8ddd4e343209379e10b3be7ea5a5b0c5a5a

Comment 15

[Arshad Khan [:arshad]]

The tests that are failing are because of the tree stuff.

Comment 16

[Jorg K (CEST = GMT+2)]

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=63ddfed158743e5738875981a2ec8db3c1845ce8

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f87c5afa28b8
Migrate results-message binding to custom element. r=mkmelin