Closed Bug 1517731 Opened 1 year ago Closed 1 year ago

Enable mochitests for maxRetransmits and maxPacketLifeTime

Categories

(Core :: WebRTC, defect, P3)

64 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: jeremy.laine, Assigned: jeremy.laine)

References

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:64.0) Gecko/20100101 Firefox/64.0

Steps to reproduce:

Some mochitests related to RTCDataChannel's maxRetransmits and maxPacketLifeTime are currently commented out saying these are not exposed in IDL.

This is no longer the case since bug 1464917 was resolved
Here the code should be uncommented and references to maxRetransmitTime changed to maxPacketLifeTime:

https://searchfox.org/mozilla-central/rev/0ee0b63732d35d16ba22d5a1120622e2e8d58c29/dom/media/tests/mochitest/dataChannel.js#134

Here we need accessors for ordered, maxRetransmits and maxPacketLifeTime:

https://searchfox.org/mozilla-central/rev/0ee0b63732d35d16ba22d5a1120622e2e8d58c29/dom/media/tests/mochitest/pc.js#684
Assignee: nobody → jeremy.laine
Rank: 25
Component: Untriaged → WebRTC
Priority: -- → P3
Product: Firefox → Core
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attachment #9034404 - Flags: review?(dminor)
Comment on attachment 9034404 [details] [diff] [review]
negotiated-datachannel.patch

Review of attachment 9034404 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm
Attachment #9034404 - Flags: review?(dminor) → review+
Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/af76ddce64a0
"Enable mochitests for maxRetransmits and maxPacketLifeTime". r=dminor
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.