1517731 - Enable mochitests for maxRetransmits and maxPacketLifeTime

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P3)

Description

[Jeremy Lainé]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:64.0) Gecko/20100101 Firefox/64.0

Steps to reproduce:

Some mochitests related to RTCDataChannel's maxRetransmits and maxPacketLifeTime are currently commented out saying these are not exposed in IDL.

This is no longer the case since bug 1464917 was resolved

Comment 1

[Jeremy Lainé]

Here the code should be uncommented and references to maxRetransmitTime changed to maxPacketLifeTime:

https://searchfox.org/mozilla-central/rev/0ee0b63732d35d16ba22d5a1120622e2e8d58c29/dom/media/tests/mochitest/dataChannel.js#134

Here we need accessors for ordered, maxRetransmits and maxPacketLifeTime:

https://searchfox.org/mozilla-central/rev/0ee0b63732d35d16ba22d5a1120622e2e8d58c29/dom/media/tests/mochitest/pc.js#684

Comment 2

[Jeremy Lainé]

Attachment: negotiated-datachannel.patch

Comment 3

[Dan Minor [:dminor]]

Try job here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=958afb9fc57b7d0bcc6e370b20787ec4f50c1e79

Comment 4

[Dan Minor [:dminor]]

Comment on attachment 9034404 [details] [diff] [review]
negotiated-datachannel.patch

Review of attachment 9034404 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/af76ddce64a0
"Enable mochitests for maxRetransmits and maxPacketLifeTime". r=dminor

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/af76ddce64a0