1517807 - redo s3mock to work with botocore >= 1.12.0

Status: RESOLVED FIXED

(Socorro :: Antenna, task, P2)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

In botocore 1.11.0, they changed how api calls are done. They no longer use the vendored requests library's HTTPAdapter and instead use URLLib3Session which uses urllib3 directly. The s3mock that we have for our tests doesn't work with that.

This bug covers redoing/fixing/ditching-for-something-else our s3mock and upgrading boto3 and botocore.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Making this a P3. It's entirely possible we will not bother doing this as we're going to GCP soon.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 296: bug 1517807: Fix s3 test class name; remove pytest-env

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #296: "bug 1517807: Fix s3 test class name; remove pytest-env" in 496b768.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Unassigning myself since I'm not going to get to this any time soon.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

Making this a P2, grabbing it, and making it block the switch to SQS because we really want to be using the latest boto3 and this is preventing that.

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 366: bug 1517807: rewrite s3mock to work with latest botocore

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #366: "bug 1517807: rewrite s3mock to work with latest botocore" in fe84543.

Comment 8

[Will Kahn-Greene [:willkg] ET needinfo? me]

This was in stage for a long while. Deployed to prod just now in bug #1600760.