1517856 - Use a variable for defining the content width for preferences

Status: RESOLVED FIXED

(Firefox :: Settings UI, enhancement, P3)

Description

[Mark Striemer [:mstriemer]]

The preferences pane has a width of 664px, this is now being matched in about:addons. This magic number is starting to spread (mostly in about:addons for reasons) so it would be nice to have a variable defined to tracks its use along with derivative values with padding subtracted.

Will file a follow up for about:addons.

https://searchfox.org/mozilla-central/rev/ecf61f8f3904549f5d65a8a511dbd7ea4fd1a51d/browser/themes/shared/incontentprefs/preferences.inc.css#19

Comment 1

[Hanna Jones [:hjones]]

It looks like there are now four different places where we are either defining a unique variable or hardcoding this value. Jules and I were thinking --page-main-content-width could be a good token name to handle all of these use cases/cover all of our about: pages.

Comment 2

[Mark Kennedy [:mark]]

Attachment: Bug 1517856 - Use shared CSS var for defining common page-level content widths r=#recomp-reviewers

• Add new token that builds CSS var

• Replace instances with new CSS var

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b6fc3265f48
Use shared CSS var for defining common page-level content widths r=reusable-components-reviewers,extension-reviewers,settings-reviewers,desktop-theme-reviewers,mconley,hjones,robwu

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/2b6fc3265f48