1931919 - Use shared tokens on about:debugging

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task)

Description

[Mark Kennedy [:mark]]

Currently, the about:debugging page doesn't use our shared token CSS vars in tokens-brand.css which prevents 1517856 from being fully implemented. Importing the shared brand tokens onto the about:debugging pages will allow us to complete future reusable component integration work and eliminate hard-coded variables.

Comment 1

[Mark Kennedy [:mark]]

Picking up from the conversation with the devtools member in https://phabricator.services.mozilla.com/D229185, we're thinking of @importing tokens-brand.css into the aboutdebugging.css file.

Comment 2

[Mark Kennedy [:mark]]

Attachment: Bug 1931919 - Use shared page width token CSS var on about:debugging pages r=#recomp-reviewers

Comment 3

[Mark Kennedy [:mark]]

Attachment: Bug 1931919 - Add shared tokens to about:debugging pages r=#recomp-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/425886fca40c
Add shared tokens to about:debugging pages r=devtools-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/56d87755d5d6
Use shared page width token CSS var on about:debugging pages r=reusable-components-reviewers,devtools-reviewers,jdescottes,hjones

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/153c2c0a129e
Backed out 2 changesets for causing dt failures @browser_parsable_css.js.

Comment 6

[agoloman]

Backed out for causing dt failures @browser_parsable_css.js.

• Backout link
• Push with failures
• Failure Log

Comment 7

[Mark Kennedy [:mark]]

After investigating, it appears the build for devtools is failing because all CSS vars in the imported tokens-brand.css file aren't being used. So Mark Striemer [:mstriemer] is looking into how to update the build tests to make an exception for the tokens-brand.css file import.

Comment 8

[Mark Striemer [:mstriemer]]

Attachment: Bug 1931919 - Allow unused design tokens in devtools in browser_parsable_css.js r?#recomp-reviewers

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b2bbab225265
Add shared tokens to about:debugging pages r=devtools-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/e18f451097b8
Use shared page width token CSS var on about:debugging pages r=reusable-components-reviewers,devtools-reviewers,jdescottes,hjones
https://hg.mozilla.org/integration/autoland/rev/cf043f73bf56
Allow unused design tokens in devtools in browser_parsable_css.js r=reusable-components-reviewers,hjones,desktop-theme-reviewers,dao

Comment 10

[amarc]

https://hg.mozilla.org/mozilla-central/rev/b2bbab225265
https://hg.mozilla.org/mozilla-central/rev/e18f451097b8
https://hg.mozilla.org/mozilla-central/rev/cf043f73bf56