Closed Bug 1518054 Opened 4 years ago Closed 4 years ago
Moving to first or last item in Downloads list does not fire accessible focus event
Bug 1518054: Move a11y focus event firing from richlistitem.current to richlistbox.currentItem to fix the All Downloads view.
47 bytes, text/x-phabricator-request
|Details | Review|
STR (with the NVDA screen reader): 1. Ensure you have at least three downloads in your downloads history. 2. Press control+j to open the Downloads window. 3. Press down arrow. Observe: The second download is spoken. 4. Press up arrow. Expected: The first download should be spoken. Actual: Only "not selected" is spoken. 5. Press down arrow. Expected: The second download should be spoken. Actual: Only "selected" is spoken. 6. Press end. Expected: The last download should be spoken. Actual: Only "not selected" is spoken. This doesn't seem to happen in all richlistbox controls; I also tested the richlistbox of categories in the Options dialog (#categories) and the list of application handlers in Options (#handlersView) and those seem to work as expected. However, I'm filing this in XUL because it seems to be a regression caused by a core XUL change: 38:49.61 INFO: Last good revision: 1bb44497f6c0601c16de02b9595402ccc661b29a 38:49.62 INFO: First bad revision: 0c7a54d4cc426d989d5759f962c8c0af737d5a5b 38:49.62 INFO: Pushlog: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=1bb44497f6c0601c16de02b9595402ccc661b29a&tochange=0c7a54d4cc426d989d5759f962c8c0af737d5a5b This indicates bug 1492326 as the cause of the regression. Curiously, when this occurs, switching to a different app and back again or opening and then dismissing a menu fires focus on the correct (first or last) item. That would suggest that the DOMMenuItemActive event fired when the list is focused is working just fine: https://searchfox.org/mozilla-central/source/toolkit/content/widgets/richlistbox.js#105 but something is going awry with the DOMMenuItemActive event fired when the current item changes while the list is already focused: https://searchfox.org/mozilla-central/source/toolkit/content/widgets/richlistbox.xml#111
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/c46ba0dfc91c Move a11y focus event firing from richlistitem.current to richlistbox.currentItem to fix the All Downloads view. r=paolo
You need to log in before you can comment on or make changes to this bug.