1518076 - Update WeTransfer extension locale files from GitHub

Status: RESOLVED FIXED

(Thunderbird :: FileLink, defect)

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1518076-wetransfer-github-1.diff [revision 6366060]

Uhhh, I guess this needs reviewing? Maybe just this time so that everyone's happy with the process.

I don't really like the moz.build verbosity, that's how Firefox do it with the Screenshots extension. I could wild-card it.

Comment 2

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 9034662 [details] [diff] [review]
1518076-wetransfer-github-1.diff [revision 6366060]

Review of attachment 9034662 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine to me. I don't mind the verbosity, but I don't have a strong opinion on it. If Jörg agrees you could land with something like rs=locales-only in the future.

Comment 3

[Geoff Lankow (:darktrojan)]

Leaving open because I know there's at least one more locale to go already. I'll make a patch for ESR which, sadly, can't take this one.

Comment 4

[Jorg K (CEST = GMT+2)]

Comment on attachment 9034662 [details] [diff] [review]
1518076-wetransfer-github-1.diff [revision 6366060]

There may not be a TB 65 beta 3. Today we built beta 2.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6b7fe97ddc71
Update WeTransfer extension locale files from GitHub; r=Fallen DONTBUILD

Comment 6

[Geoff Lankow (:darktrojan)]

Attachment: 1518076-wetransfer-do-l10n-1.diff

Somehow actually using the translated strings never landed in c-c, yet is in the GitHub version. This patch fixes that.

Comment 7

[Geoff Lankow (:darktrojan)]

Attachment: 1518076-wetransfer-do-l10n-2.diff

Sigh… adding the strings would help.

Comment 8

[Jorg K (CEST = GMT+2)]

ESR 60 is covered in bug 1504508?

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2959a4850c6e
Use localised strings in WeTransfer settings page. r=philipp

Comment 10

[Jorg K (CEST = GMT+2)]

Linting error: mail/components/cloudfile/wetransfer/content/moments.js:7:27 | 'browser' is not defined. (no-undef)

Is that the browser M-C just got rid of?

Comment 11

[Magnus Melin [:mkmelin]]

This is causing the build failure, apparently?

ERROR: The following duplicated files are not allowed:
[task 2019-01-10T18:11:16.036Z] 18:11:16 INFO - package> features/[e-mail]/_locales/en/messages.json
[task 2019-01-10T18:11:16.037Z] 18:11:16 INFO - package> features/[e-mail]/_locales/en-GB/messages.json

Where is the github repo for this, and why is it an "en" and not an en-US locale?

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/14387ecf405c
Follow-up: Allow duplicate wetransfer locales for en and en-GB. rs=bustage-fix

Comment 13

[:aceman]

The eslint error is still there, can you please fix it?

Comment 14

[Geoff Lankow (:darktrojan)]

Attachment: 1518076-wetransfer-lint.diff

Comment 15

[Geoff Lankow (:darktrojan)]

(In reply to Jorg K (GMT+1) from comment #8)

ESR 60 is covered in bug 1504508?

It isn't, since this bug will need further updates, I'll make a patch for ESR when but 1504508 lands there.

(In reply to Jorg K (GMT+1) from comment #10)

Linting error: mail/components/cloudfile/wetransfer/content/moments.js:7:27 | 'browser' is not defined. (no-undef)

Is that the browser M-C just got rid of?

No.

(In reply to Magnus Melin [:mkmelin] from comment #11)

This is causing the build failure, apparently?

ERROR: The following duplicated files are not allowed:
[task 2019-01-10T18:11:16.036Z] 18:11:16 INFO - package> features/[e-mail]/_locales/en/messages.json
[task 2019-01-10T18:11:16.037Z] 18:11:16 INFO - package> features/[e-mail]/_locales/en-GB/messages.json

Where is the github repo for this, and why is it an "en" and not an en-US locale?

Oh, ew. I kinda wish they hadn't bothered making an en_GB "translation".

The repo is at https://github.com/thundernest/wetransfer-extension. It's not en-US because, uhhh, I screwed up. I wonder how badly Pontoon will break if I change it.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/317ae9663d95
Fix linting error in WeTransfer extension; rs=me DONTBUILD

Comment 17

[Jorg K (CEST = GMT+2)]

TB 65 beta 3:
https://hg.mozilla.org/releases/comm-beta/rev/0f6e3ac081e93e96c507bbcb6fc637e1f0e6e242
https://hg.mozilla.org/releases/comm-beta/rev/f4d16faced06f2872da2d66f8ef8f623432ef838
https://hg.mozilla.org/releases/comm-beta/rev/def81e026d016e67859ae43e7356508ba8090b5b
https://hg.mozilla.org/releases/comm-beta/rev/8c04d754f176d44922db2339bb16082f4d0e58e3

Comment 18

[Geoff Lankow (:darktrojan)]

Attachment: 1518076-wetransfer-github-2.diff [revision 900f53b]

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4954bbdf8fc6
Update WeTransfer extension locale files from GitHub; rs=l10n-only

Comment 20

[Geoff Lankow (:darktrojan)]

Attachment: 1518076-wetransfer-github-3.diff [revision b2471e2]

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/79eb92913221
Update WeTransfer extension locale files from GitHub; rs=l10n-only DONTBUILD

Comment 22

[Geoff Lankow (:darktrojan)]

Attachment: 1518076-wetransfer-github-4.diff [revision f0bfbb2]

Comment 23

[Geoff Lankow (:darktrojan)]

Attachment: 1518076-wetransfer-github-esr-4.diff [revision f0bfbb2 for ESR]

Comment 24

[Jorg K (CEST = GMT+2)]

TB 60.5.1:
https://hg.mozilla.org/releases/comm-esr60/rev/4f286d77b34542ff6437d79ab2234268f580065d

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0c74c709d828
Update WeTransfer extension locale files from GitHub; rs=l10n-only

Comment 26

[Jorg K (CEST = GMT+2)]

TB 66 beta 2:
https://hg.mozilla.org/releases/comm-beta/rev/075a50a73036e99590cc8ba5d6844a28bbf5053e

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/35cf3ac150f7
Update WeTransfer extension locale files from GitHub; rs=l10n-only

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/822213ee1da6
Update WeTransfer extension locale files from GitHub; rs=L10n-only

Comment 29

[Geoff Lankow (:darktrojan)]

Attachment: 1518076-wetransfer-github-esr-5.diff [revision 81fb7d5 for ESR]

Comment 30

[Jorg K (CEST = GMT+2)]

Comment on attachment 9049843 [details] [diff] [review]
1518076-wetransfer-github-esr-5.diff [revision 81fb7d5 for ESR]

https://hg.mozilla.org/releases/comm-esr60/rev/50ed13edf80d4809deb5143d9295a8858e59c6cb

Thanks! This will go into TB 60.6.

Comment 31

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/56e98e6ee7d7
Update WeTransfer extension locale files from GitHub; rs=L10n-only

Comment 32

[Jorg K (CEST = GMT+2)]

Anything to do for ESR60 here?

Comment 33

[Onno Ekker [:nONoNonO UTC+1]]

Is this going to be integrated in TB or will it stay an extension? I thought it only was an extension because of localization?

Comment 34

[Jorg K (CEST = GMT+2)]

It is already integrated.

Comment 35

[Onno Ekker [:nONoNonO UTC+1]]

The strings aren't, they are in a separate repo on Pontoon and github, instead of under comm-central.
This was good because it allowed for faster translation outside of the ESR-loop, but is also bad, because it isn't localized in all the locales of Thunderbird.

Comment 36

[Magnus Melin [:mkmelin]]

I think we should move to doing only the normal localization now.

Comment 37

[Jorg K (CEST = GMT+2)]

Geoff, I'm a bit confused here. The stuff from comment #31 doesn't need to go to beta 67 and ESR?

Comment 38

[Geoff Lankow (:darktrojan)]

In my opinion, this stuff can ride the trains to beta town. As for ESR, let me know when you're preparing one and I'll make a patch. There may be more updates to do (there are).

Comment 39

[Jorg K (CEST = GMT+2)]

ESR time!!

Comment 40

[Geoff Lankow (:darktrojan)]

Attachment: 1518076-wetransfer-github-esr-6.diff [revision e6f4fa0 for ESR]

Two of these locales aren't on c-c yet, but I'll do that at the next merge.

Comment 41

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/46fb17116c05
Update WeTransfer extension locale files from GitHub; rs=L10n-only

Comment 42

[Jorg K (CEST = GMT+2)]

Comment on attachment 9063934 [details] [diff] [review]
1518076-wetransfer-github-esr-6.diff [revision e6f4fa0 for ESR]

Thanks. Only after requesting these I learned that the next branch date was shifted by a week.

Comment 43

[Jorg K (CEST = GMT+2)]

Comment on attachment 9063934 [details] [diff] [review]
1518076-wetransfer-github-esr-6.diff [revision e6f4fa0 for ESR]

TB 60.7 ESR:
https://hg.mozilla.org/releases/comm-esr60/rev/29e8a0eb1dcb920cc9fa1990459d230ce8060b34

Comment 44

[Geoff Lankow (:darktrojan)]

Calling this fixed. There's been no new stuff for 4 months.

Comment 45

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2da9397f95af
Update WeTransfer extension locale files from GitHub; rs=L10n-only