Closed Bug 1518076 Opened 5 years ago Closed 5 years ago

Update WeTransfer extension locale files from GitHub

Categories

(Thunderbird :: FileLink, defect)

Product:
Thunderbird
Component:
FileLink
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird65 fixed, thunderbird66 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 66.0
Tracking Flags:
Tracking Status
thunderbird65 --- fixed
thunderbird66 --- fixed

People

(Reporter: darktrojan, Assigned: darktrojan)

References

Details

Attachments

(9 files, 1 obsolete file)

1518076-wetransfer-github-1.diff [revision 6366060]
16.71 KB, patch
Fallen
: review+
jorgk-bmo
: approval-comm-beta+
Details | Diff | Splinter Review
1518076-wetransfer-do-l10n-2.diff
3.23 KB, patch
Fallen
: review+
jorgk-bmo
: approval-comm-beta+
Details | Diff | Splinter Review
1518076-wetransfer-lint.diff
1.12 KB, patch
Details | Diff | Splinter Review
1518076-wetransfer-github-2.diff [revision 900f53b]
13.27 KB, patch
Details | Diff | Splinter Review
1518076-wetransfer-github-3.diff [revision b2471e2]
7.30 KB, patch
Details | Diff | Splinter Review
1518076-wetransfer-github-4.diff [revision f0bfbb2]
2.48 KB, patch
darktrojan
: review+
jorgk-bmo
: approval-comm-beta+
Details | Diff | Splinter Review
1518076-wetransfer-github-esr-4.diff [revision f0bfbb2 for ESR]
10.44 KB, patch
jorgk-bmo
: approval-comm-esr60+
Details | Diff | Splinter Review
1518076-wetransfer-github-esr-5.diff [revision 81fb7d5 for ESR]
9.48 KB, patch
jorgk-bmo
: approval-comm-esr60+
Details | Diff | Splinter Review
1518076-wetransfer-github-esr-6.diff [revision e6f4fa0 for ESR]
5.88 KB, patch
jorgk-bmo
: approval-comm-esr60+
Details | Diff | Splinter Review 
      No description provided.
Summary: Update locale files from GitHub → Update WeTransfer extension locale files from GitHub
Uhhh, I guess this needs reviewing? Maybe just this time so that everyone's happy with the process.

I don't really like the moz.build verbosity, that's how Firefox do it with the Screenshots extension. I could wild-card it.
Attachment #9034662 - Flags: review?(philipp)
Attachment #9034662 - Flags: approval-comm-beta?
Comment on attachment 9034662 [details] [diff] [review]
1518076-wetransfer-github-1.diff [revision 6366060]

Review of attachment 9034662 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine to me. I don't mind the verbosity, but I don't have a strong opinion on it. If Jörg agrees you could land with something like rs=locales-only in the future.
Attachment #9034662 - Flags: review?(philipp) → review+
Keywords: checkin-needed, leave-open

Leaving open because I know there's at least one more locale to go already. I'll make a patch for ESR which, sadly, can't take this one.

Comment on attachment 9034662 [details] [diff] [review]
1518076-wetransfer-github-1.diff [revision 6366060]

There may not be a TB 65 beta 3. Today we built beta 2.

Attachment #9034662 - Flags: approval-comm-beta? → approval-comm-beta+
Attachment #9034662 - Attachment description: 1518076-wetransfer-github-1.diff → 1518076-wetransfer-github-1.diff [revision 6366060]
Blocks: 1504508

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/6b7fe97ddc71
Update WeTransfer extension locale files from GitHub; r=Fallen DONTBUILD

Keywords: checkin-needed
Target Milestone: --- → Thunderbird 66.0

Somehow actually using the translated strings never landed in c-c, yet is in the GitHub version. This patch fixes that.

Attachment #9035432 - Flags: review?(philipp)
Attachment #9035432 - Flags: approval-comm-beta?

Sigh… adding the strings would help.

Attachment #9035442 - Flags: review?(philipp)
Attachment #9035442 - Flags: approval-comm-beta?
Attachment #9035432 - Attachment is obsolete: true
Attachment #9035432 - Flags: review?(philipp)
Attachment #9035432 - Flags: approval-comm-beta?
Attachment #9035442 - Flags: review?(philipp) → review+

ESR 60 is covered in bug 1504508?

Flags: needinfo?(geoff)
Attachment #9035442 - Flags: approval-comm-beta? → approval-comm-beta+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/2959a4850c6e
Use localised strings in WeTransfer settings page. r=philipp

Linting error: mail/components/cloudfile/wetransfer/content/moments.js:7:27 | 'browser' is not defined. (no-undef)

Is that the browser M-C just got rid of?

This is causing the build failure, apparently?

ERROR: The following duplicated files are not allowed:
[task 2019-01-10T18:11:16.036Z] 18:11:16 INFO - package> features/wetransfer@extensions.thunderbird.net/_locales/en/messages.json
[task 2019-01-10T18:11:16.037Z] 18:11:16 INFO - package> features/wetransfer@extensions.thunderbird.net/_locales/en-GB/messages.json

Where is the github repo for this, and why is it an "en" and not an en-US locale?

Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/14387ecf405c
Follow-up: Allow duplicate wetransfer locales for en and en-GB. rs=bustage-fix

The eslint error is still there, can you please fix it?

Flags: needinfo?(geoff)
Keywords: checkin-needed

(In reply to Jorg K (GMT+1) from comment #8)

ESR 60 is covered in bug 1504508?

It isn't, since this bug will need further updates, I'll make a patch for ESR when but 1504508 lands there.

(In reply to Jorg K (GMT+1) from comment #10)

Linting error: mail/components/cloudfile/wetransfer/content/moments.js:7:27 | 'browser' is not defined. (no-undef)

Is that the browser M-C just got rid of?

No.

(In reply to Magnus Melin [:mkmelin] from comment #11)

This is causing the build failure, apparently?

ERROR: The following duplicated files are not allowed:
[task 2019-01-10T18:11:16.036Z] 18:11:16 INFO - package> features/wetransfer@extensions.thunderbird.net/_locales/en/messages.json
[task 2019-01-10T18:11:16.037Z] 18:11:16 INFO - package> features/wetransfer@extensions.thunderbird.net/_locales/en-GB/messages.json

Where is the github repo for this, and why is it an "en" and not an en-US locale?

Oh, ew. I kinda wish they hadn't bothered making an en_GB "translation".

The repo is at https://github.com/thundernest/wetransfer-extension. It's not en-US because, uhhh, I screwed up. I wonder how badly Pontoon will break if I change it.

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/317ae9663d95
Fix linting error in WeTransfer extension; rs=me DONTBUILD

Keywords: checkin-needed
Keywords: checkin-needed

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/4954bbdf8fc6
Update WeTransfer extension locale files from GitHub; rs=l10n-only

Keywords: checkin-needed
Keywords: checkin-needed
Attachment #9039477 - Attachment description: 1518076-wetransfer-github-3.diff → 1518076-wetransfer-github-3.diff [revision b2471e2]

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/79eb92913221
Update WeTransfer extension locale files from GitHub; rs=l10n-only DONTBUILD

Keywords: checkin-needed
Keywords: checkin-needed
Attachment #9042893 - Flags: approval-comm-esr60?
Attachment #9042892 - Flags: review+
Attachment #9042892 - Flags: approval-comm-beta?
Attachment #9042892 - Flags: approval-comm-beta? → approval-comm-beta+
Attachment #9042893 - Flags: approval-comm-esr60? → approval-comm-esr60+

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/0c74c709d828
Update WeTransfer extension locale files from GitHub; rs=l10n-only

Keywords: checkin-needed
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/35cf3ac150f7
Update WeTransfer extension locale files from GitHub; rs=l10n-only
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/822213ee1da6
Update WeTransfer extension locale files from GitHub; rs=L10n-only
Comment on attachment 9049843 [details] [diff] [review]
1518076-wetransfer-github-esr-5.diff [revision 81fb7d5 for ESR]

https://hg.mozilla.org/releases/comm-esr60/rev/50ed13edf80d4809deb5143d9295a8858e59c6cb

Thanks! This will go into TB 60.6.
Attachment #9049843 - Flags: approval-comm-esr60? → approval-comm-esr60+
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/56e98e6ee7d7
Update WeTransfer extension locale files from GitHub; rs=L10n-only

Anything to do for ESR60 here?

Is this going to be integrated in TB or will it stay an extension? I thought it only was an extension because of localization?

It is already integrated.

The strings aren't, they are in a separate repo on Pontoon and github, instead of under comm-central.
This was good because it allowed for faster translation outside of the ESR-loop, but is also bad, because it isn't localized in all the locales of Thunderbird.

I think we should move to doing only the normal localization now.

Geoff, I'm a bit confused here. The stuff from comment #31 doesn't need to go to beta 67 and ESR?

Flags: needinfo?(geoff)

In my opinion, this stuff can ride the trains to beta town. As for ESR, let me know when you're preparing one and I'll make a patch. There may be more updates to do (there are).

Flags: needinfo?(geoff)

ESR time!!

Flags: needinfo?(geoff)

Two of these locales aren't on c-c yet, but I'll do that at the next merge.

Flags: needinfo?(geoff)
Attachment #9063934 - Flags: approval-comm-esr60?
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/46fb17116c05
Update WeTransfer extension locale files from GitHub; rs=L10n-only
Comment on attachment 9063934 [details] [diff] [review]
1518076-wetransfer-github-esr-6.diff [revision e6f4fa0 for ESR]

Thanks. Only after requesting these I learned that the next branch date was shifted by a week.
Attachment #9063934 - Flags: approval-comm-esr60? → approval-comm-esr60+
Comment on attachment 9063934 [details] [diff] [review]
1518076-wetransfer-github-esr-6.diff [revision e6f4fa0 for ESR]

TB 60.7 ESR:
https://hg.mozilla.org/releases/comm-esr60/rev/29e8a0eb1dcb920cc9fa1990459d230ce8060b34

Calling this fixed. There's been no new stuff for 4 months.

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: leave-open
Resolution: --- → FIXED
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/2da9397f95af
Update WeTransfer extension locale files from GitHub; rs=L10n-only
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: