1518113 - Use the "application" role for Preferences in Firefox 65

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P1)

Description

[:Paolo Amadini]

We need to revert the Preferences document to the "application" role on Beta to prevent bug 1514687 from happening, to give us more time for testing a patch that fixes the underlying issue in Nightly.

Comment 1

[:Paolo Amadini]

Attachment: Bug 1518113 - Use the "application" role for Preferences in Firefox 65. r=Jamie

Comment 2

[:Paolo Amadini]

Jamie, can you confirm that this prevents bug 1514687 from happening?

Comment 3

[James Teh [:Jamie]]

It'd be more correct to say that it makes it less likely that most users will encounter this, since a user can still force treatment as a document and thus encounter this problem. But... yes, this restores the previous behaviour.

Comment 4

[:Paolo Amadini]

Comment on attachment 9034695 [details]
Bug 1518113 - Use the "application" role for Preferences in Firefox 65. r=Jamie

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1429940

User impact if declined: Bug 1514687

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce:

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): This restores the previous behavior.

String changes made/needed:

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9034695 [details]
Bug 1518113 - Use the "application" role for Preferences in Firefox 65. r=Jamie

[Triage Comment]
Reverts us back to previous known-good behavior. Approved for 65.0b10.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9886aad5caeb