1518403 - Make IsCurrent reflect the animation's playback rate

Status: RESOLVED FIXED

(Core :: DOM: Animation, defect, P3)

Description

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Based on whatever spec changes come out of:

https://github.com/w3c/csswg-drafts/issues/3193

Comment 1

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Let's see what breaks: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4c3a047882d627cd9e6918f5932ca1cf72dfc428

Comment 2

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Seems good. Made spec PR: https://github.com/w3c/csswg-drafts/pull/3490

Comment 3

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1518403 - Make "is current" depend on the direction of the associated animation's playback rate; r?hiro

As per the following spec change:

  https://github.com/w3c/csswg-drafts/commit/4ec1deb76ab7a6d6cf4cd6818dc63387ea595884

Spec issue:

  https://github.com/w3c/csswg-drafts/issues/3193

Of the added test cases, only the last one, "Returns reversed animations yet to
reach their active phase" fails without this code change. The others pass
because the animation is finished at that point but I added them for consistency
with the previous tests.

Comment 4

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Try run with zero playback rate animations not considered "is current" for before/after phase:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d0d6905f340bfe61e2384eee3af8eb30641fff8

Comment 5

[Brian Birtles (:birtles, Feb 26~ parental leave)]

And adding a test case that we run these animations on the compositor (i.e. that bug 1330498 is fixed):
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d3bb3f0ba7c5b44bec57cf8691d580e20539cb78

Comment 6

[Hiroyuki Ikezoe (:hiro)]

(Thanks for fixing typos there.)

Comment 7

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1518403 - Make IsCurrent return false for animations with playback rate == 0 that are in before/active phase; r?hiro

As per following spec update:

  https://github.com/w3c/csswg-drafts/commit/0c369c0806921246d0f3914341aa37daa9a753c9

Depends on D16001

Comment 9

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1518403 - Add test that animations with a negative playback rate are sent to the compositor even in the delay phase; r?hiro

Depends on D16131

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f8fa3111ea8e
Make "is current" depend on the direction of the associated animation's playback rate; r=hiro
https://hg.mozilla.org/integration/autoland/rev/052892f1cbd1
Make IsCurrent return false for animations with playback rate == 0 that are in before/active phase; r=hiro
https://hg.mozilla.org/integration/autoland/rev/2f2b4d6aabeb
Add test that animations with a negative playback rate are sent to the compositor even in the delay phase; r=hiro

Comment 11

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/f8fa3111ea8e
https://hg.mozilla.org/mozilla-central/rev/052892f1cbd1
https://hg.mozilla.org/mozilla-central/rev/2f2b4d6aabeb

Comment 12

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/14793 for changes under testing/web-platform/tests