1518559 - [remote-dbg-next] Dispatch select page failure action if the page argument is missing

Status: RESOLVED FIXED

(DevTools :: about:debugging, enhancement, P1)

Description

[Julian Descottes [:jdescottes]]

Follow up form Bug 1515612. We are adding a SELECT_PAGE_FAILURE action, so we would dispatch it in case the action is called without the page argument. Or rather than dispatching it, we could simply throw an error and let the try/catch dispatch the appropriate action:

  if (!page || isSamePage(currentPage, page)) {
    return;
  }

Currently we silently bail out. Note that isSamePage(currentPage, page) should still do that, we should only throw if page is missing.

Comment 1

[Ola Gasidlo [:ogasidlo] [:ola] OOO - please ping :ladybenko:]

Attachment: Bug 1518559 - Throw error, if page is missing. r=ladybenko,jdescottes

Throw error and dispatch select page failure action if the page argument is missing

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cfc581f4768c
Throw error, if page is missing. r=ladybenko,jdescottes

Comment 3

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/cfc581f4768c