1515612 - [remote-dbg-next] Runtime page is not updated when closing Network Location runtime

Status: RESOLVED FIXED

(DevTools :: about:debugging, defect, P1)

Description

[Julian Descottes [:jdescottes]]

STRs:
- start one Firefox in regular mode
- start another Firefox in remote debug mode (eg `./mach run --start-debugger-server -P someOtherProfile`). Debug port should be in the terminal "Started debugger server on 6080"
- open about:debugging-new on first Firefox
- enable network locations in about:config (devtools.aboutdebugging.network)
- go to connect page, add a network location for the second firefox "localhost:6080"
- connect to it and select it to open its runtime page
- quit the debugger server Firefox

ER: The runtime page should close, or indicate that the server is no longer available
AR: Nothing happens, the page is still displayed, you can click on buttons but nothing happens.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1515612 - Split PAGE_SELECTED action in START/SUCCESS/FAILURE subactions;r=ladybenko,daisuke,ola

Depends on D15410

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1515612 - Update Network runtimes after receiving closed event on Debugger client;r=ladybenko,ola

Depends on D15414

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1515612 - Disconnect all the invalid clients when updating remote clients;r=ladybenko,ola

Depends on D15415

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1515612 - Test navigation to this-firefox when a remote client closes;r=ladybenko,ola

Depends on D15416

Comment 5

[Julian Descottes [:jdescottes]]

try https://treeherder.mozilla.org/#/jobs?repo=try&revision=61468313098d2870170e9df5d73b03fac33bc390

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eee3227176bb
Split PAGE_SELECTED action in START/SUCCESS/FAILURE subactions;r=ladybenko,Ola
https://hg.mozilla.org/integration/autoland/rev/97b28c1b8a85
Update Network runtimes after receiving closed event on Debugger client;r=ladybenko,Ola
https://hg.mozilla.org/integration/autoland/rev/552427e973d5
Disconnect all the invalid clients when updating remote clients;r=ladybenko
https://hg.mozilla.org/integration/autoland/rev/5345e8472f29
Test navigation to this-firefox when a remote client closes;r=ladybenko,Ola

Comment 7

[Cristian Brindusan [:cbrindusan]]

Backed out 4 changesets (Bug 1515612) for ESlint error on runtimes.js.

Backout: https://hg.mozilla.org/integration/autoland/rev/5d5c62405e28ac0cc173f556834f68451ec3f6eb

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=5345e8472f29cd844c8218b50051c01f8aa12aee&selectedJob=220860187

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=220860187&repo=autoland&lineNumber=290

Comment 8

[Julian Descottes [:jdescottes]]

Attachment: Bug 1515612 - Remove unneeded addListener;r=ladybenko

I landed this by mistake in https://bugzilla.mozilla.org/show_bug.cgi?id=1495382
Sorry :/

Comment 9

[Cristian Brindusan [:cbrindusan]]

There are also dt6 failures oon browser_aboutdebugging_addons_remote_runtime.js
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=220872793&repo=autoland&lineNumber=1494

Comment 10

[Julian Descottes [:jdescottes]]

try after last rebase & fixes: https://treeherder.mozilla.org/#/jobs?repo=try&revision=94ef60791167ff0d883ea67632f6a93f34e6424f

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/66a7369d4c51
Remove unneeded addListener;r=ladybenko
https://hg.mozilla.org/integration/autoland/rev/958fb1212e11
Split PAGE_SELECTED action in START/SUCCESS/FAILURE subactions;r=ladybenko,Ola
https://hg.mozilla.org/integration/autoland/rev/9fc243c2626c
Update Network runtimes after receiving closed event on Debugger client;r=ladybenko,Ola
https://hg.mozilla.org/integration/autoland/rev/d19483d0f411
Disconnect all the invalid clients when updating remote clients;r=ladybenko
https://hg.mozilla.org/integration/autoland/rev/5caf4fb0d4f6
Test navigation to this-firefox when a remote client closes;r=ladybenko,Ola

Comment 13

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/66a7369d4c51
https://hg.mozilla.org/mozilla-central/rev/958fb1212e11
https://hg.mozilla.org/mozilla-central/rev/9fc243c2626c
https://hg.mozilla.org/mozilla-central/rev/d19483d0f411
https://hg.mozilla.org/mozilla-central/rev/5caf4fb0d4f6

Comment 16

[Hani Yacoub, Desktop QA]

Attachment: devtools afterclosing networklocation.png

Verified as fixed on Firefox Nightly 68.0a1, Firefox Dev Edition 67.0b4 and on Firefox 66.0.1 on Windows 10 x 64, Mac OS X 10.14 and on Ubuntu 16.04 x64 as "This Nightly" tab is selected after closing Network Location runtime.

But what is the expected behavior of the devtools toolbox of the debugger server after closing Network Location runtime?
When the focus is on "Console/Debugger" panel, devtools toolbox turns blank (keeping the same URL as before).
When the focus is on "Inspector" panel, devtools toolbox doesn't turn blank totally. (See screenshot attached)

Comment 17

[Julian Descottes [:jdescottes]]

This is currently being worked on in Bug 1505368. For now the target is to remain on the same URL but show an error message.