1518626 - Add more tests for scroll anchoring

Status: RESOLVED FIXED

(Core :: Layout: Scrolling and Overflow, enhancement, P3)

Description

[Ryan Hunt [:rhunt] (on leave until early May)]

We've found some additional cases that could use test coverage in the implementation of scroll anchoring.

I don't want to block the initial landing of scroll anchoring on adding them, so I'm filing this bug for them.

Comment 1

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Bug 1518626 - Add scroll-anchoring tests for excluding certain elements from anchor selection. r?dholbert

This commit adds two tests around anchor selection.

The first tests that 'position: sticky' is an invalid subtree, which is new to
the spec. The second tests that implementations respect 'overflow-anchor' on
the table element, and don't get confused with the boxes generated by tables.

Comment 2

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Bug 1518626 - Add scroll-anchoring test for anchor in fragmented <div>. r?dholbert

This commit adds a test that implementations can anchor to node that's inside
of a fragmented node.

Depends on D16274

Comment 3

[Ryan Hunt [:rhunt] (on leave until early May)]

This shouldn't block release of scroll anchoring.

Comment 4

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Bug 1518626 - Add test for negative scrollable overflow rect clamping. r?dholbert

This is a regression test to catch the scrolling issue we experienced
in Gmail.

Depends on D16275

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0db1ecc6676e
Add scroll-anchoring tests for excluding certain elements from anchor selection. r=dholbert
https://hg.mozilla.org/integration/mozilla-inbound/rev/f38628954fbc
Add scroll-anchoring test for anchor in fragmented <div>. r=dholbert
https://hg.mozilla.org/integration/mozilla-inbound/rev/05d0f0893f36
Add test for negative scrollable overflow rect clamping. r=dholbert

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/0db1ecc6676e
https://hg.mozilla.org/mozilla-central/rev/f38628954fbc
https://hg.mozilla.org/mozilla-central/rev/05d0f0893f36

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/0db1ecc6676e
https://hg.mozilla.org/mozilla-central/rev/f38628954fbc
https://hg.mozilla.org/mozilla-central/rev/05d0f0893f36

Comment 8

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/14964 for changes under testing/web-platform/tests