Page scroll position is not consistent while content is loading (implement "scroll anchoring")
Categories
(Core :: Layout, defect, P3)
Tracking
()
People
(Reporter: bugzilla, Assigned: rhunt)
References
(Depends on 1 open bug, Blocks 4 open bugs, Regressed 1 open bug, )
Details
(Keywords: dev-doc-complete, feature, Whiteboard: [geckoview:p2][wptsync upstream])
Attachments
(16 files, 1 obsolete file)
7.33 KB,
text/html
|
Details | |
19.27 KB,
patch
|
Details | Diff | Splinter Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review |
Comment 1•8 years ago
|
||
Comment 3•8 years ago
|
||
Updated•8 years ago
|
Comment 4•8 years ago
|
||
Comment 7•8 years ago
|
||
Comment 8•7 years ago
|
||
Comment 9•7 years ago
|
||
Updated•7 years ago
|
Updated•7 years ago
|
Assignee | ||
Comment 12•6 years ago
|
||
Comment 13•6 years ago
|
||
Updated•6 years ago
|
Updated•6 years ago
|
Assignee | ||
Comment 14•6 years ago
|
||
Assignee | ||
Comment 15•6 years ago
|
||
Assignee | ||
Comment 16•6 years ago
|
||
Assignee | ||
Comment 17•6 years ago
|
||
Assignee | ||
Comment 18•6 years ago
|
||
Assignee | ||
Comment 19•6 years ago
|
||
Assignee | ||
Comment 20•6 years ago
|
||
Assignee | ||
Comment 21•6 years ago
|
||
Assignee | ||
Comment 22•6 years ago
|
||
Assignee | ||
Comment 23•6 years ago
|
||
Assignee | ||
Comment 24•6 years ago
|
||
Assignee | ||
Comment 25•6 years ago
|
||
Assignee | ||
Comment 26•6 years ago
|
||
Assignee | ||
Comment 27•6 years ago
|
||
Assignee | ||
Comment 28•6 years ago
|
||
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Updated•6 years ago
|
Assignee | ||
Comment 29•6 years ago
|
||
I've filed some bugs for follow-up work.
I have patches for most of them, but don't want to delay landing the initial implementation in nightly for them to be reviewed.
Assignee | ||
Comment 30•6 years ago
|
||
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Assignee | ||
Comment 31•6 years ago
|
||
Assignee | ||
Comment 32•6 years ago
|
||
Try run looks good [1]. There's just one last issue I found in a devtools test. Once the commit to fix that is reviewed, we should be good to go.
[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=53b6c49a9f82bf7427683ba10b78460fa87fc786
Comment 33•6 years ago
|
||
Comment 34•6 years ago
|
||
Comment 35•6 years ago
|
||
Backed out 15 changesets (Bug 1305957) for ASAN failures.
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=51c86d025ecb710b8d37d3454a1d0adcfff8f89d&selectedJob=221114559
Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/842b7a62d9cefd5030c5561d536af8414899af7a
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=221114559&repo=mozilla-inbound&lineNumber=1905
Comment 36•6 years ago
|
||
The following first appeared on the initial 14 changesets push:
Assignee | ||
Comment 37•6 years ago
|
||
The issue was an invalid lifetime assumption in RestyleManager. Here's an ASAN run with the fix applied [1]
[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=1770f59bdc9ce00399f699b3477ea0dca57a94d8
Comment 38•6 years ago
|
||
Comment 41•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4e60d1fb951f
https://hg.mozilla.org/mozilla-central/rev/8c9be913b3e6
https://hg.mozilla.org/mozilla-central/rev/399c5fe7c934
https://hg.mozilla.org/mozilla-central/rev/52a6a35a238d
https://hg.mozilla.org/mozilla-central/rev/b6c42df7ce09
https://hg.mozilla.org/mozilla-central/rev/462f25bfdc65
https://hg.mozilla.org/mozilla-central/rev/a4257d0470d7
https://hg.mozilla.org/mozilla-central/rev/eef9ed24a061
https://hg.mozilla.org/mozilla-central/rev/3f00aed52fb3
https://hg.mozilla.org/mozilla-central/rev/4b492273f763
https://hg.mozilla.org/mozilla-central/rev/da81605d3695
https://hg.mozilla.org/mozilla-central/rev/f2ff150468c2
https://hg.mozilla.org/mozilla-central/rev/a245309e92fd
https://hg.mozilla.org/mozilla-central/rev/e31c9494b9a6
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 42•6 years ago
|
||
I've filed bug 1519644 to be the general meta-bug for all scroll anchoring issues, whether they block the initial release or are future improvements that would be good to do (I expect more of these over time).
Bug 1515946 will still be just for issues blocking the initial release.
Assignee | ||
Updated•6 years ago
|
Comment 43•6 years ago
|
||
Ryan, can you suggest a release note? Thanks!
Assignee | ||
Comment 44•6 years ago
|
||
I'll do my best, please edit as necessary.
"Improved scrolling behavior: Firefox will now attempt to keep content from jumping around while a page is loading by supporting scroll anchoring."
Updated•6 years ago
|
Comment 47•6 years ago
|
||
Comment 48•6 years ago
|
||
Hello, I installed Firefox 66 beta but I don't find this feature as reliable as it is on Google Chrome. Here is an example link where scroll anchoring doesn't appear to work at all, unless I'm missing something:
https://discuss.flarum.org/d/5293-rainbow-comic-sans/22
The /22 at the end of the URL makes the page scroll to a specific post in the page (the one with ID 22).
When I load the URL with Chrome, the scrolling correctly "points" to the text message by "Ralkage", with ID 22 (you can check that by clicking on the date near the author of the message).
When I load the URL with Firefox, a different message is shown at the top of the page. Specifically, the image contained in the post with ID 21 (by "0E800") is shown, because it is loaded after the page was scrolled down, causing a content jump.
I've done the tests using incognito mode in order to avoid image caching.
Is this a scenario that is not covered by scroll anchoring?
Thanks.
Comment 49•6 years ago
|
||
(In reply to matteo from comment #48)
FWIW, it's easy to miss stuff in closed bugs, it's better if you file a new one blocking this one.
Hello, I installed Firefox 66 beta but I don't find this feature as reliable as it is on Google Chrome. Here is an example link where scroll anchoring doesn't appear to work at all, unless I'm missing something:
https://discuss.flarum.org/d/5293-rainbow-comic-sans/22
The /22 at the end of the URL makes the page scroll to a specific post in the page (the one with ID 22).
When I load the URL with Chrome, the scrolling correctly "points" to the text message by "Ralkage", with ID 22 (you can check that by clicking on the date near the author of the message).
When I load the URL with Firefox, a different message is shown at the top of the page. Specifically, the image contained in the post with ID 21 (by "0E800") is shown, because it is loaded after the page was scrolled down, causing a content jump.
This looks like a fairly complex test-case, where there's not only scroll anchoring at play, there needs to be other stuff going on as well (they need to manually call scrollIntoView(), I'd guess). So it's not clear to me if scroll anchoring is at play at all here, or it's just the page making bad assumptions, or is other kind of Firefox bug.
In any case, please do file a bug for this. Feel free to CC me and Ryan (:rhunt), and we can try to take a look... A sort of reduced test-case would be immensely helpful to diagnose this though, do you know if Disqus' code is open source somewhere? Otherwise it's much harder to debug.
Comment 50•6 years ago
|
||
Comment 51•6 years ago
|
||
bugherder |
Comment 52•6 years ago
|
||
Note to MDN writers — I've added a note to the Fx66 rel notes to cover this: https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/66#CSS
I think the docs probably need a page for overflow-anchor, and a page to expain what this feature is and show some kind of demo.
Comment 53•6 years ago
|
||
Docs complete; Rachel Andrew wrote a ref page for overflow-anchor, and a brief explainer
https://developer.mozilla.org/en-US/docs/Web/CSS/overflow-anchor
https://developer.mozilla.org/en-US/docs/Web/CSS/overflow-anchor/Guide_to_scroll_anchoring
Description
•