Closed
Bug 1518994
Opened 5 years ago
Closed 5 years ago
Enable NEON in AudioNodeEngine on aarch64
Categories
(Core :: Web Audio, enhancement, P2)
Tracking
()
RESOLVED
FIXED
mozilla66
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: m_kato, Assigned: m_kato)
References
Details
Attachments
(1 file)
No description provided.
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → m_kato
OS: Unspecified → Android
Hardware: Unspecified → ARM64
Summary: Enable → Enable NEON in AudioNodeEngine on aarch64
|
|
Assignee | |
Comment 1•5 years ago
|
||
OpenMAX IL doesn't fully support on aarch64 and we don't define BUILD_ARM_NEON on aarch64 (bug 1303952)...
|
|
Assignee | |
Comment 2•5 years ago
|
||
s/OpenMAX IL/OpenMAX DL/
|
||
Comment 3•5 years ago
|
||
ffmpeg has aarch64 assembly for FFTs. We'd need to import fft_init_aarch64.c and fft_neon.S from libavcodec/aarch64 into ffvpx, similarly to some of what was done in bug 1476231.
|
|
Assignee | |
Comment 4•5 years ago
|
||
Although we don't define BUILD_ARM_NEON on aarch64 (bug 1303952), aarch64 supports NEON, so we should turn on NEON for AudioNodeEngine. OpenMAX DL doesn't support aarch64 since we modify some codes. So FFTBlock.h still use ARM32 only. Also, MSVC cannot use arm_neon.h header, doesn't allow `float32x4_t zero = {0, 0, 0, 0};` and throws compiler warning. So we need some workarounds to use this on MSVC.
|
||
Updated•5 years ago
|
Rank: 15
Priority: -- → P2
Pushed by m_kato@ga2.so-net.ne.jp: https://hg.mozilla.org/integration/autoland/rev/ebca585ed555 Enable NEON in AudioNodeEngine on aarch64. r=drno
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in
before you can comment on or make changes to this bug.
Description
•