Closed
Bug 1520021
Opened 5 years ago
Closed 5 years ago
clang-cl should not use AudioNodeEngine's NEON workarounds
Categories
(Core :: Web Audio, defect)
Core
Web Audio
Tracking
()
RESOLVED
FIXED
mozilla66
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: away, Assigned: away)
References
Details
Attachments
(1 file)
1014 bytes,
patch
|
drno
:
review+
|
Details | Diff | Splinter Review |
clang-cl can work with arm_neon.h natively; including arm64_neon.h confuses it and leads to linking errors.
Assignee: nobody → dmajor
Attachment #9036450 -
Flags: review?(drno)
Comment 2•5 years ago
|
||
Comment on attachment 9036450 [details] [diff] [review] Bug 1520021 - clang-cl should not use AudioNodeEngine's NEON workarounds Review of attachment 9036450 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #9036450 -
Flags: review?(drno) → review+
Pushed by dmajor@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4b0600db127a clang-cl should not use AudioNodeEngine's NEON workarounds. r=drno
Comment 4•5 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in
before you can comment on or make changes to this bug.
Description
•