Closed Bug 1520021 Opened 7 months ago Closed 7 months ago

clang-cl should not use AudioNodeEngine's NEON workarounds

Categories

(Core :: Web Audio, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: dmajor, Assigned: dmajor)

References

Details

Attachments

(1 file)

clang-cl can work with arm_neon.h natively; including arm64_neon.h confuses it and leads to linking errors.

Assignee: nobody → dmajor
Attachment #9036450 - Flags: review?(drno)
Comment on attachment 9036450 [details] [diff] [review]
Bug 1520021 - clang-cl should not use AudioNodeEngine's NEON workarounds

Review of attachment 9036450 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #9036450 - Flags: review?(drno) → review+
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4b0600db127a
clang-cl should not use AudioNodeEngine's NEON workarounds. r=drno
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.