1519077 - Int32AddResult and other instructions shouldn't clobber the RHS register

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect, P1)

Description

[Jan de Mooij [:jandem]]

See https://searchfox.org/mozilla-central/rev/5053031ba7621fa8f63f42de4c204ab3561e4e59/js/src/jit/CacheIRCompiler.cpp#2149

Comment 1

[Jan de Mooij [:jandem]]

(Needinfo for when you get back..)

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

There's a number of these that I'll fix in one fell swoop.

Comment 3

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1519077 - Don't mutate inputs in CacheIR operations r?jandem

Comment 4

[Nicolas B. Pierron [:nbp]]

Please be creaful when using AutoScratchRegister outside the MacroAssembler, as this might not work well across all architecture.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a75915b2541
Don't mutate inputs in CacheIR operations r=jandem

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c332d5df8ce7
Backed out 2 changesets (bug 1519077, bug 1526024) for jsapi-tests failures on a CLOSED TREE

Comment 7

[Raul Gurzau (:RaulG)]

Backed out 2 changesets (bug 1519077, bug 1526024) for jsapi-tests failures on a CLOSED TREE

Backout link: https://hg.mozilla.org/integration/autoland/rev/c332d5df8ce7cabfcc0224dd319907bfe32780a7

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=8a75915b2541f5ad01212ec087ea067bf50a1ce0

Failures appeared here: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=177cf2f812d59db13ad3f7fde4dfa227fe03de21&selectedJob=230628908

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=230628908&repo=autoland&lineNumber=2073

Log snippet:

[task 2019-02-26T21:40:35.171Z] 21:40:35 INFO - TEST-PASS | testNewContext | ok
[task 2019-02-26T21:40:35.171Z] 21:40:35 INFO - testOOM
[task 2019-02-26T21:40:35.172Z] 21:40:35 INFO - TEST-PASS | testOOM | ok
[task 2019-02-26T21:40:35.172Z] 21:40:35 INFO - testNullRoot
[task 2019-02-26T21:40:35.173Z] 21:40:35 INFO - TEST-PASS | testNullRoot | ok
[task 2019-02-26T21:40:35.173Z] 21:40:35 INFO - testNewTargetInvokeConstructor
[task 2019-02-26T21:40:35.173Z] 21:40:35 INFO - TEST-PASS | testNewTargetInvokeConstructor | ok
[task 2019-02-26T21:40:35.174Z] 21:40:35 INFO - testNewObjrhs clobbered 2(lhsOutput/srcDest) %eax flexibleLshift32 (shift/rhs) %ecx
[task 2019-02-26T21:40:35.174Z] 21:40:35 WARNING - TEST-UNEXPECTED-FAIL | jsapi-tests | test failed with return code -5
[task 2019-02-26T21:40:35.175Z] 21:40:35 INFO - TEST-INFO took 24172ms
[task 2019-02-26T21:40:35.175Z] 21:40:35 INFO - SUITE-END | took 40s
[task 2019-02-26T21:40:35.176Z] 21:40:35 INFO - Result summary:
[task 2019-02-26T21:40:35.176Z] 21:40:35 INFO - cppunittests INFO | Passed: 60
[task 2019-02-26T21:40:35.176Z] 21:40:35 WARNING - cppunittests INFO | Failed: 1
[task 2019-02-26T21:40:35.177Z] 21:40:35 WARNING - One or more unittests failed.
[task 2019-02-26T21:40:35.177Z] 21:40:35 ERROR - Return code: 1
[task 2019-02-26T21:40:35.178Z] 21:40:35 INFO - TinderboxPrint: cppunittest-cppunittest<br/>60/<em class="testfail">1</em>
[task 2019-02-26T21:40:35.178Z] 21:40:35 WARNING - # TBPL FAILURE #
[task 2019-02-26T21:40:35.178Z] 21:40:35 WARNING - setting return code to 2
[task 2019-02-26T21:40:35.178Z] 21:40:35 WARNING - The cppunittest suite: cppunittest ran with return status: FAILURE

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46246cd080fa
Don't mutate inputs in CacheIR operations r=jandem

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/46246cd080fa