1526024 - flexibleShift methods don't handle rcx/ecx as destination properly

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement, P1)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

The flexibleShift helpers don't correctly handle ecx as a destination register.

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1526024 - Handle rcx as a destination register r?tcampbell

Also add unit tests

Comment 2

[Nicolas B. Pierron [:nbp]]

Ted, when would you be able to review the patch attached on this bug?

Comment 3

[Ted Campbell [:tcampbell]]

(Requested some changes from Matthew to better match flexibleDivMod32)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/87514c3aaa3a
Handle rcx as a destination register r=tcampbell

Comment 5

[Raul Gurzau (:RaulG)]

Backed out 2 changesets (bug 1519077, bug 1526024) for jsapi-tests failures on a CLOSED TREE

Backout link: https://hg.mozilla.org/integration/autoland/rev/c332d5df8ce7cabfcc0224dd319907bfe32780a7

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=8a75915b2541f5ad01212ec087ea067bf50a1ce0

Failures appeared here: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=177cf2f812d59db13ad3f7fde4dfa227fe03de21&selectedJob=230628908

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=230628908&repo=autoland&lineNumber=2073

Log snippet:

[task 2019-02-26T21:40:35.171Z] 21:40:35 INFO - TEST-PASS | testNewContext | ok
[task 2019-02-26T21:40:35.171Z] 21:40:35 INFO - testOOM
[task 2019-02-26T21:40:35.172Z] 21:40:35 INFO - TEST-PASS | testOOM | ok
[task 2019-02-26T21:40:35.172Z] 21:40:35 INFO - testNullRoot
[task 2019-02-26T21:40:35.173Z] 21:40:35 INFO - TEST-PASS | testNullRoot | ok
[task 2019-02-26T21:40:35.173Z] 21:40:35 INFO - testNewTargetInvokeConstructor
[task 2019-02-26T21:40:35.173Z] 21:40:35 INFO - TEST-PASS | testNewTargetInvokeConstructor | ok
[task 2019-02-26T21:40:35.174Z] 21:40:35 INFO - testNewObjrhs clobbered 2(lhsOutput/srcDest) %eax flexibleLshift32 (shift/rhs) %ecx
[task 2019-02-26T21:40:35.174Z] 21:40:35 WARNING - TEST-UNEXPECTED-FAIL | jsapi-tests | test failed with return code -5
[task 2019-02-26T21:40:35.175Z] 21:40:35 INFO - TEST-INFO took 24172ms
[task 2019-02-26T21:40:35.175Z] 21:40:35 INFO - SUITE-END | took 40s
[task 2019-02-26T21:40:35.176Z] 21:40:35 INFO - Result summary:
[task 2019-02-26T21:40:35.176Z] 21:40:35 INFO - cppunittests INFO | Passed: 60
[task 2019-02-26T21:40:35.176Z] 21:40:35 WARNING - cppunittests INFO | Failed: 1
[task 2019-02-26T21:40:35.177Z] 21:40:35 WARNING - One or more unittests failed.
[task 2019-02-26T21:40:35.177Z] 21:40:35 ERROR - Return code: 1
[task 2019-02-26T21:40:35.178Z] 21:40:35 INFO - TinderboxPrint: cppunittest-cppunittest<br/>60/<em class="testfail">1</em>
[task 2019-02-26T21:40:35.178Z] 21:40:35 WARNING - # TBPL FAILURE #
[task 2019-02-26T21:40:35.178Z] 21:40:35 WARNING - setting return code to 2
[task 2019-02-26T21:40:35.178Z] 21:40:35 WARNING - The cppunittest suite: cppunittest ran with return status: FAILURE

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b8712597ac57
Handle rcx as a destination register r=tcampbell

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b8712597ac57