Closed Bug 1519273 Opened 10 months ago Closed 9 months ago

Log telemetry for Intermediate CA Preloading

Categories

(Core :: Security: PSM, enhancement, P1)

65 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: jcj, Assigned: jcj)

References

Details

(Whiteboard: [psm-assigned])

Attachments

(2 files)

Build telemetry for intermediate preloading to answer questions like:

  • How many intermediates are preloaded by this client?
  • How many download failures occurred?
Blocks: 1520278

Adds telemetry for the state of intermediate preloading, as well as what errors
occur during the process.

Dana- will solicit data review today, too.

Attached file Data Collection Review
Attachment #9043355 - Flags: review?(chutten)
Comment on attachment 9043355 [details]
Data Collection Review

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is Telemetry so is documented in its definitions file ([Histograms.json](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Histograms.json)), the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/), and on telemetry.mozilla.org's [Measurement Dashboards](https://telemetry.mozilla.org/new-pipeline/dist.html).

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

N/A, this collection expires in Firefox 70.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

    Is the data collection request for default-on or default-off?

Default on for prerelease channels only.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

Yes. :jcj is responsible for removing or renewing this collection before it expires in Firefox 70.

---
Result: datareview+
Attachment #9043355 - Flags: review?(chutten) → review+

Chris,

Is there any issue with making INTERMEDIATE_PRELOADING_NUM_PRELOADED and INTERMEDIATE_PRELOADING_NUM_PENDING scalars? (per review comments)

Flags: needinfo?(chutten)

There is no data collection impact as Scalars aren't a materially different collection mechanism to Histograms. (If we went with, for example, Events then we'd have to evaluate if the timestamps and order of events impacted the category of the collection.) Thank you for asking!

Though I should mention for anyone coming across this later that the definitions file becomes Scalars.yaml.

Flags: needinfo?(chutten)
Pushed by jjones@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7aaf38e67da9
Log telemetry for Intermediate CA Preloading r=keeler,janerik
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.