1553299 - Perma security/manager/ssl/tests/unit/test_intermediate_preloads.js | xpcshell return code: 0 when Gecko version number increases to 70 on 2019-07-08

Status: VERIFIED DUPLICATE of bug 1553550

(Core :: Security: PSM, defect, P2)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This fails because the probe INTERMEDIATE_PRELOADING_ERRORS expires in Gecko 70: https://searchfox.org/mozilla-central/rev/6c9f60f8cc064a1005cd8141ecd526578ae9da7a/toolkit/components/telemetry/Histograms.json#13562

Version increase simulation: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=1a7d27e9716b885fa3e1a697d896781f76d0c6fb&selectedJob=247536825

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=247536825&repo=try

[task 2019-05-21T12:52:03.335Z] 12:52:03 INFO - TEST-PASS | security/manager/ssl/tests/unit/test_intermediate_preloads.js | test_preload_invalid_hash - [test_preload_invalid_hash : 285] Preloading update should have run - "success" == "success"
[task 2019-05-21T12:52:03.336Z] 12:52:03 INFO - Unexpected exception TypeError: histogram is undefined at /builds/worker/workspace/build/tests/xpcshell/tests/security/manager/ssl/tests/unit/test_intermediate_preloads.js:59
[task 2019-05-21T12:52:03.337Z] 12:52:03 INFO - countTelemetryReports@/builds/worker/workspace/build/tests/xpcshell/tests/security/manager/ssl/tests/unit/test_intermediate_preloads.js:59:17
[task 2019-05-21T12:52:03.338Z] 12:52:03 INFO - test_preload_invalid_hash@/builds/worker/workspace/build/tests/xpcshell/tests/security/manager/ssl/tests/unit/test_intermediate_preloads.js:291:9
[task 2019-05-21T12:52:03.340Z] 12:52:03 INFO - async*run_next_test/_run_next_test/<@/builds/worker/workspace/build/tests/xpcshell/head.js:1437:22
[task 2019-05-21T12:52:03.341Z] 12:52:03 INFO - _run_next_test@/builds/worker/workspace/build/tests/xpcshell/head.js:1437:38
[task 2019-05-21T12:52:03.342Z] 12:52:03 INFO - run@/builds/worker/workspace/build/tests/xpcshell/head.js:688:9
[task 2019-05-21T12:52:03.343Z] 12:52:03 INFO - _do_main@/builds/worker/workspace/build/tests/xpcshell/head.js:227:6
[task 2019-05-21T12:52:03.344Z] 12:52:03 INFO - _execute_test@/builds/worker/workspace/build/tests/xpcshell/head.js:529:5
[task 2019-05-21T12:52:03.345Z] 12:52:03 INFO - @-e:1:1

Comment 1

[J.C. Jones [:jcj] (he/they)]

Will remove in Bug 1553550

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:keeler, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Dana Keeler (she/her) (use needinfo) [:keeler]]

This is basically blocked by bug 1553550, which will remove the relevant telemetry probe (which probably could have been done in this bug but no big deal).

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Changing the priority to p2 as the bug is tracked by a release manager for the current nightly.
See What Do You Triage for more information

Comment 5

[Kate Hudson :k88hudson]

Looks like this is blocked on a bug that is not prioritized, does that need to be updated?

Comment 6

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Set the priority.

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed by latest version increase simulation: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=b18f0867fe28ed0b62789869e614fdccbb7965f8