1519433 - Port Bug 1513241 Pass loadURIOptions dictionary for docshell loads

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Jorg K (CEST = GMT+2)]

Instead of passing single parameters, this now passes an object:
https://hg.mozilla.org/mozilla-central/rev/71cb45922e34#l1.12

We have a few call-sites
https://searchfox.org/comm-central/search?q=webnav.*LoadURI&case=false&regexp=true&path=
in C++ and JS code.

Comment 1

[Jorg K (CEST = GMT+2)]

Attachment: 1519433-loaduri.patch (v0)

This compiles but the JS part is missing. Coming up.

Comment 2

[Jorg K (CEST = GMT+2)]

Attachment: 1519433-loaduri.patch (v1)

First reviewer wins. I couldn't test chat since it's broken (bug 1519091).

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/77f1eb52e155
Port bug 1513241: Adjust parameters of nsIWebNavigation.loadURI(). rs=bustage-fix

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9035954 [details] [diff] [review]
1519433-loaduri.patch (v1)

Review of attachment 9035954 [details] [diff] [review]:
-----------------------------------------------------------------

r=mkmelin

::: mailnews/base/src/nsMsgWindow.cpp
@@ +505,5 @@
>  
>    nsCOMPtr<nsIWebNavigation> webNav(do_QueryInterface(docShell));
>    NS_ENSURE_TRUE(webNav, NS_ERROR_FAILURE);
>  
> +  mozilla::dom::LoadURIOptions loadURIOptions;

slightly awkward not to just add the needed namescape on top and use LoadURIOptions

Comment 5

[Jorg K (CEST = GMT+2)]

Usually we don't use namaspaces much:
https://dxr.mozilla.org/comm-central/search?q=mozilla%3A%3A+path%3Acomm%2F&redirect=false
or more specific:
https://dxr.mozilla.org/comm-central/search?q=mozilla%3A%3Adom%3A%3A+path%3Acomm%2F&redirect=false

Only nsMsgCompose.cpp and nsMsgSend.cpp have using namespace mozilla::dom;:
https://dxr.mozilla.org/comm-central/search?q=namespace+mozilla%3A%3Adom+path%3Acomm%2F&redirect=false

So I think this is inline with current practise.

Comment 6

[Magnus Melin [:mkmelin]]

Well practice is to copy as much as we can from core, right? And they seem to use namespaces.
Someone more c++ could chim in, but is there any reason we shouldn't use them?