1519659 - Need to reload the page before being able to edit

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

File a bug.
Immediately try to edit comment 0

Expected: editing works
Actual: the textbox goes into some weird state that's not actually editable

Need to reload the page before editing works. Sane thing happens for trying to edit a comment you just made.

Comment 1

[Kohei Yoshino [:kohei]]

I thought the issue was solved in Bug 1510770 before releasing the comment editing feature. Maybe a dup of Bug 1514275?

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Bug 1514275 is different, I have experienced that and it looks different than this bug. Let me see if using the "Edit bug" button helps with editing this comment.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

So hitting "Edit bug" before trying to edit the comment seems to work.

Hm and just now I was able to edit this comment right after submitting it too. So maybe it only applies to comment 0 (i.e. on a new bug)? I think I've seen it on subsequent comments before but I'm not certain.

Comment 4

[Botond Ballo [:botond]]

I've seen this too.

(In reply to Kartikaya Gupta (away Jan 12-26; email:[e-mail]) from comment #0)

Actual: the textbox goes into some weird state that's not actually editable

Specifically, the state is one where the comment has a grey background. Normally, it enters this state for a fraction of a second, and then it becomes editable. The bug here seems to be that it gets stuck in that state.

Comment 5

[Kohei Yoshino [:kohei]]

I can reproduce the issue on my local dev server. The console complains TypeError: this.str is undefined so this is a variant of Bug 1510770. PR is coming shortly.

Comment 6

[Kohei Yoshino [:kohei]]

Attachment: GitHub Pull Request

Comment 7

[Kohei Yoshino [:kohei]]

Merged to master.