1519791 - Remove unused --toolbarbutton*-border-color variables

Status: RESOLVED FIXED

(DevTools :: General, enhancement)

Description

[Tim Nguyen :ntim]

All the --toolbarbutton-* variables were originally introduced for the Firebug theme.

But out of those, the following are the least useful after the Firebug theme removal:

--toolbarbutton-border-color
--toolbarbutton-hover-border-color
--toolbarbutton-checked-border-color

They're all 3 set to transparent all the time...

Lines to replace with border: none;:

https://searchfox.org/mozilla-central/rev/c43240cef5829b8a2dec118faff8a5e1fec6ae1b/devtools/client/jsonview/css/toolbar.css#22

https://searchfox.org/mozilla-central/rev/c43240cef5829b8a2dec118faff8a5e1fec6ae1b/devtools/client/themes/common.css#274

Lines to delete:

https://searchfox.org/mozilla-central/rev/c43240cef5829b8a2dec118faff8a5e1fec6ae1b/devtools/client/themes/variables.css#207,209,214

https://searchfox.org/mozilla-central/rev/c43240cef5829b8a2dec118faff8a5e1fec6ae1b/devtools/client/jsonview/css/toolbar.css#36

https://searchfox.org/mozilla-central/rev/c43240cef5829b8a2dec118faff8a5e1fec6ae1b/devtools/client/themes/toolbox.css#245,247

https://searchfox.org/mozilla-central/rev/c43240cef5829b8a2dec118faff8a5e1fec6ae1b/devtools/client/themes/common.css#378,398

Comment 1

[Garvit Khatri [:garvitdelhi]]

Attachment: Remove unused --toolbarbutton*-border-color variables

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b78ecfce1c78
Remove unused --toolbarbutton*-border-color variables. r=ntim

Comment 3

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/b78ecfce1c78

Comment 4

[Mike de Boer [:mikedeboer]]

https://hg.mozilla.org/projects/cedar/rev/b78ecfce1c782db32e171fc0854f41f886bcb8c0
Bug 1519791 - Remove unused --toolbarbutton*-border-color variables. r=ntim