Closed Bug 1519804 Opened 1 year ago Closed 1 year ago

Additional license notices for libgcrypt etc. needed by Thunderbird

Categories

(Chat Core :: Security: OTR, enhancement)

enhancement
Not set

Tracking

(thunderbird_esr68 fixed, thunderbird69 fixed, thunderbird70 fixed)

RESOLVED FIXED
Instantbird 70
Tracking Status
thunderbird_esr68 --- fixed
thunderbird69 --- fixed
thunderbird70 --- fixed

People

(Reporter: KaiE, Assigned: KaiE)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

This was originally mentioned in bug 1518091. Forked here as separate bug. This is relevant if we are indeed adding libcrypt.

libgcrypt includes some code with additional (compatible) licenses, which requires that permission notices are included. We'll have to check which of the following require additions to about:license:
https://git.gnupg.org/cgi-bin/gitweb.cgi?p=libgcrypt.git;a=blob;f=LICENSES;h=f6733a69246bb2d0236af42cff28c1a6fee43c36;hb=HEAD

Thunderbird will import additional third party licenses into its source tree, which will require additional license notices in the binary, so they must be included in about:license.

Should these additions be made to the general set of licenses contained in toolkit? Or should they become private additions only for the mail applications, only (inside the comm repository).

If you "only add to Mail app's set of licenses", how should we do that technically? Will we need scripts, that use build time logic to combine the contents of toolkit/content/license.html with additional contents for comm applications?

Flags: needinfo?(mhoye)
Summary: License notices for libgcrypt → Additional license notices for libgcrypt etc. needed by Thunderbird
Blocks: 1518164
Blocks: 1518166
Flags: needinfo?(mkmelin+mozilla)
Depends on: 1559900
Attached patch 1519804-v1.patch (obsolete) — Splinter Review

This patch requires the suggested enhancement from bug 1559900.

It adds the license notices from libgcrypt.

The other libraries, libgpg-error and libotr, don't seem to need additional notices, beyond what we already show.

Assignee: nobody → kaie
Attachment #9072619 - Flags: review?(mhoye)
Flags: needinfo?(mkmelin+mozilla)
Attached patch 1519804-v2.patch (obsolete) — Splinter Review

Adjusted for patch v2 from bug 1559900.

Attachment #9072619 - Attachment is obsolete: true
Attachment #9072619 - Flags: review?(mhoye)
Attachment #9074445 - Flags: review?(mhoye)

There's a circular dependency between this bug and bug 1518164.

We cannot import the code until we have the license added.

However, before we can add the license, we need to know in which directory the code will be placed, because the license page mentions the filenames that the license is related to. And that's being discussed in bug 1518164.

It has been clarified that we'll use directory name third_party (toplevel in comm-central). I'll attach an updated patch.

Attached patch 1519804-v3.patchSplinter Review
Attachment #9074445 - Attachment is obsolete: true
Attachment #9074445 - Flags: review?(mhoye)
Attachment #9076771 - Flags: review?(mkmelin+mozilla)
Flags: needinfo?(mhoye)

Once reviewed, this will require uplift to the comm-esr68 branch.

It depends on bug 1559900, we'll need to uplift that one to Thunderbird's v68 release branch of mozilla-esr68.

Flags: needinfo?(jorgk)
Comment on attachment 9076771 [details] [diff] [review]
1519804-v3.patch

No NI needed here, the flag will do it (unlike bug 1559900).
Flags: needinfo?(jorgk)
Attachment #9076771 - Flags: approval-comm-esr68+
Comment on attachment 9076771 [details] [diff] [review]
1519804-v3.patch

Review of attachment 9076771 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin
Attachment #9076771 - Flags: review?(mkmelin+mozilla) → review+
Keywords: checkin-needed
Status: NEW → ASSIGNED

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/082bd1210cb5
Add additional license notices for libgcrypt, etc. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Instantbird 70
Comment on attachment 9076771 [details] [diff] [review]
1519804-v3.patch

Bug 1559900 has been uplifted to mozilla-beta (tracked in bug 1566397).

We could uplift this one to comm-beta, too, for consistency.
Attachment #9076771 - Flags: approval-comm-beta?
Comment on attachment 9076771 [details] [diff] [review]
1519804-v3.patch

Sure, this is for TB 69 beta.
Attachment #9076771 - Flags: approval-comm-beta? → approval-comm-beta+
Component: General → Security: OTR
You need to log in before you can comment on or make changes to this bug.