1559900 - Allow applications to add sections to about:license

Status: RESOLVED FIXED

(mozilla.org :: Licensing, task)

Description

[Kai Engert (:KaiE:)]

Thunderbird needs to display additional licenses in about:license

I suggest to add placeholders that an app can replace.

Comment 1

[Kai Engert (:KaiE:)]

Attachment: 1559900-v1.patch

Comment 2

[Kai Engert (:KaiE:)]

I'd like to make use of this in bug 1519804.

Comment 3

[Mike Hoye [:mhoye]]

While I don't object to this in principle, I would like to see some additional information clarifying that these added licenses are product-specific to non-Firefox apps, and not part of the main corpus of Firefox licenses. Can we add some additional text (and maybe a code comment, if not something more enforceable?) clarifying that?

Comment 4

[Kai Engert (:KaiE:)]

Attachment: 1559900-v2.patch

How about this?

In addition to the comments, it includes a fixed header text that talks about product specific licenses, and requires the definition of a product name.

Comment 5

[Kai Engert (:KaiE:)]

Attachment: 1559900-v3.patch

Further improvement (and a syntax fix).

This patch enforces that all three variables are declared.

Comment 6

[Mike Hoye [:mhoye]]

Comment on attachment 9074446 [details] [diff] [review]
1559900-v3.patch

This works. Thanks for making the change.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ddd1e312fb0a
Allow applications to add sections to about:license. r=mhoye

Comment 8

[Kai Engert (:KaiE:)]

This will require uplift to Thunderbird's release branch of mozilla-esr68.

Comment 9

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/ddd1e312fb0a

Comment 10

[Jorg K (CEST = GMT+2)]

I've put it on my list of patches for our release branch, clearing NI now.

Comment 11

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ae93580605ab

Comment 12

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/releases/mozilla-esr68/rev/f844f1b563a8fcc2afbc49a94d732389e633c40e on THUNDERBIRD_68_VERBRANCH

Comment 13

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/releases/mozilla-esr68/rev/2804109b79fa95c99ef8d81bde46d2dbd03a0a60 on THUNDERBIRD_68_VERBRANCH for >= 68.1