Closed Bug 1559900 Opened 1 year ago Closed 1 year ago

Allow applications to add sections to about:license

Categories

(mozilla.org :: Licensing, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: KaiE, Assigned: KaiE)

References

Details

Attachments

(1 file, 2 obsolete files)

Thunderbird needs to display additional licenses in about:license

I suggest to add placeholders that an app can replace.

Attached patch 1559900-v1.patch (obsolete) — Splinter Review
Assignee: mhoye → kaie
Attachment #9072618 - Flags: review?(mhoye)

I'd like to make use of this in bug 1519804.

Blocks: 1519804

While I don't object to this in principle, I would like to see some additional information clarifying that these added licenses are product-specific to non-Firefox apps, and not part of the main corpus of Firefox licenses. Can we add some additional text (and maybe a code comment, if not something more enforceable?) clarifying that?

Attached patch 1559900-v2.patch (obsolete) — Splinter Review

How about this?

In addition to the comments, it includes a fixed header text that talks about product specific licenses, and requires the definition of a product name.

Attachment #9072618 - Attachment is obsolete: true
Attachment #9072618 - Flags: review?(mhoye)
Attachment #9074443 - Flags: review?(mhoye)
Attached patch 1559900-v3.patchSplinter Review

Further improvement (and a syntax fix).

This patch enforces that all three variables are declared.

Attachment #9074443 - Attachment is obsolete: true
Attachment #9074443 - Flags: review?(mhoye)
Attachment #9074446 - Flags: review?(mhoye)
Comment on attachment 9074446 [details] [diff] [review]
1559900-v3.patch

This works. Thanks for making the change.
Attachment #9074446 - Flags: review?(mhoye) → review+
Pushed by kaie@kuix.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ddd1e312fb0a
Allow applications to add sections to about:license. r=mhoye

This will require uplift to Thunderbird's release branch of mozilla-esr68.

Flags: needinfo?(jorgk)
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Blocks: 1566397

I've put it on my list of patches for our release branch, clearing NI now.

Flags: needinfo?(jorgk)
You need to log in before you can comment on or make changes to this bug.