1519840 - Stop onItemChanged updates for annotations

Status: RESOLVED FIXED

(Toolkit :: Places, enhancement, P3)

Description

[Mark Banner (:standard8)]

Most of the annotations have now been removed, as a result we think we should be able to stop onItemChanged updates for annotations and remove associated code.

The basic idea being:

• Remove code that notifies from within nsAnnotationService
• Add a comment to onItemChanged that aIsAnnotationProperty is deprecated
• Remove code in onItemChanged handlers that handle aIsAnnotationProperty being true.

Comment 1

[Mark Banner (:standard8)]

Lina, can you confirm that there's no adverse effect for Sync whilst we still need to support the "sync/parent" annotation, or do we need to hold off until that's removed?

Comment 2

[Lina Butler [:lina]]

Remove away! :-) Sync completely ignores anno changes in its onItemChanged listener, now that livemarks, descriptions, and load in sidebar are gone. https://searchfox.org/mozilla-central/rev/b29663c6c9c61b0bf29e8add490cbd6bad293a67/services/sync/modules/engines/bookmarks.js#33-36,1378-1381 could go away entirely.

Comment 3

[Marco Bonardo [:mak]]

Attachment: Bug 1519840 - Stop onItemChanged updates for annotations. r=Standard8

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b6316cb29acb
Stop onItemChanged updates for annotations. r=Standard8

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/b6316cb29acb