Closed Bug 1519840 Opened 2 years ago Closed 2 years ago

Stop onItemChanged updates for annotations

Categories

(Toolkit :: Places, enhancement, P3)

Product:
Toolkit
Component:
Places
Type:
enhancement
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Iteration:
69.2 - May 27 - Jun 9
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: standard8, Assigned: mak)

References

Details

Attachments

(1 file)

Bug 1519840 - Stop onItemChanged updates for annotations. r=Standard8
47 bytes, text/x-phabricator-request
Details | Review

Most of the annotations have now been removed, as a result we think we should be able to stop onItemChanged updates for annotations and remove associated code.

The basic idea being:

  • Remove code that notifies from within nsAnnotationService
  • Add a comment to onItemChanged that aIsAnnotationProperty is deprecated
  • Remove code in onItemChanged handlers that handle aIsAnnotationProperty being true.

Lina, can you confirm that there's no adverse effect for Sync whilst we still need to support the "sync/parent" annotation, or do we need to hold off until that's removed?

Blocks: 1460577
Flags: needinfo?(lina)

Remove away! :-) Sync completely ignores anno changes in its onItemChanged listener, now that livemarks, descriptions, and load in sidebar are gone. https://searchfox.org/mozilla-central/rev/b29663c6c9c61b0bf29e8add490cbd6bad293a67/services/sync/modules/engines/bookmarks.js#33-36,1378-1381 could go away entirely.

Flags: needinfo?(lina)
Priority: -- → P3
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Iteration: --- → 69.2 - May 27 - Jun 9
Points: --- → 1
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/b6316cb29acb
Stop onItemChanged updates for annotations. r=Standard8

https://hg.mozilla.org/mozilla-central/rev/b6316cb29acb

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.