Closed Bug 1519923 Opened 11 months ago Closed 10 months ago

Migrate about:rights to Fluent

Categories

(Toolkit :: General, defect, P3)

64 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: jaws, Assigned: chengy12, Mentored)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

about:rights uses two DTD files, aboutRights.dtd and security.dtd. security.dtd is not referenced from any other file.

Both of these file should be migrated to Fluent, and the string from security.dtd can be moved to aboutRights.ftl since it is not referenced from anywhere else.

Please note that aboutRights.dtd is referenced by Android build files and the patch will need to update those files accordingly.

Priority: -- → P3
Assignee: nobody → chengy12
Status: NEW → ASSIGNED

Yuan is struggling here because, despite converting everything, fluent is not running so the page just looks empty.

This is because of the security checks at https://searchfox.org/mozilla-central/rev/330daedbeac2bba296d663668e0e0cf248bc6823/dom/base/Document.cpp#2032-2057 that will only allow fluent to run on pages that the web can't link to, or that are UI resources. about:rights is linkable by web content (see bug 1308351), and not marked as a UI resource, so we don't run fluent.

I'll file a dep bug to fix the web-linkability of about:rights now that about:home and about:newtab aren't web-linkable anymore. The only other about: pages that would then not be localizable would be about:logo (which is just a png), about:blank, about:srcdoc (both web-modifiable, so that's correct) and about:license, which doesn't have localizable content ( https://searchfox.org/mozilla-central/source/toolkit/content/license.html ) so hopefully that will be all...

Depends on: 1521730
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/75766cc3befd
Migrate about:rights to Fluent, r=jaws,flod
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Depends on: 1528573
Regressions: 1528573
No longer depends on: 1528573
You need to log in before you can comment on or make changes to this bug.