Change test_bug199692.xul to use getBoundingClientRect instead of box object properties

RESOLVED FIXED in Firefox 67

Status

()

defect
P3
normal
RESOLVED FIXED
5 months ago
4 months ago

People

(Reporter: enndeakin, Assigned: enndeakin)

Tracking

unspecified
mozilla67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

5 months ago

This test is one where the box object coordinates do not return the same values as getBoundingClientRect, due to a 'position: relative' parent. I think the test might just work by coincidence. Fortunately, the correct coordinates returned by getBoundingClientRect work as well.

Attachment #9036401 - Flags: review?(paolo.mozmail)
Assignee

Updated

5 months ago
Summary: Fix → Change test_bug199692.xul to use getBoundingClientRect instead of box object properties
Assignee

Updated

5 months ago
Assignee: nobody → enndeakin
Assignee

Updated

5 months ago
Priority: -- → P3

Comment 1

5 months ago

Comment on attachment 9036401 [details] [diff] [review]
boxobject-test199692

Thanks! Worth including part of comment 0 in the detailed description of the commit.

Attachment #9036401 - Flags: review?(paolo.mozmail) → review+

Comment 2

4 months ago
Pushed by neil@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d576a84575c4
change test_bug199692.xul to use getBoundingClientRect instead of box object properties. This test is one where the box object coordinates do not return the same values as getBoundingClientRect, due to a 'position: relative' parent. The test likely worked coincidentally, but the correct coordinates returned by getBoundingClientRect work as well, r=paolo

Comment 3

4 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.