Closed Bug 1519950 Opened 5 years ago Closed 5 years ago

Change test_bug199692.xul to use getBoundingClientRect instead of box object properties

Categories

(Core :: XUL, defect, P3)

Product:
Core
Component:
XUL
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: enndeakin, Assigned: enndeakin)

References

Details

Attachments

(1 file)

boxobject-test199692
1.98 KB, patch
Paolo
: review+
Details | Diff | Splinter Review

This test is one where the box object coordinates do not return the same values as getBoundingClientRect, due to a 'position: relative' parent. I think the test might just work by coincidence. Fortunately, the correct coordinates returned by getBoundingClientRect work as well.

Attachment #9036401 - Flags: review?(paolo.mozmail)
Summary: Fix → Change test_bug199692.xul to use getBoundingClientRect instead of box object properties
Assignee: nobody → enndeakin
Priority: -- → P3

Comment on attachment 9036401 [details] [diff] [review]
boxobject-test199692

Thanks! Worth including part of comment 0 in the detailed description of the commit.

Attachment #9036401 - Flags: review?(paolo.mozmail) → review+
Pushed by neil@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d576a84575c4
change test_bug199692.xul to use getBoundingClientRect instead of box object properties. This test is one where the box object coordinates do not return the same values as getBoundingClientRect, due to a 'position: relative' parent. The test likely worked coincidentally, but the correct coordinates returned by getBoundingClientRect work as well, r=paolo

https://hg.mozilla.org/mozilla-central/rev/d576a84575c4

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: