1519948 - Remove box objects

Status: RESOLVED FIXED

(Core :: XUL, enhancement, P3)

Comment 1

[Neil Deakin]

Attachment: Remove box objects

Comment 2

[Neil Deakin]

Attachment: Bug 1519948, remove XUL box objects, r?bzbarsky

Comment 3

[Boris Zbarsky [:bzbarsky]]

Jorg, you may need to deal with this on the comm-central side...

Comment 4

[Jorg K (CEST = GMT+2)]

Thanks Boris, can you please give me some details on what to look for or what to replace. Then I'll file a bug with those details.

Comment 5

[Neil Deakin]

element.boxObject.x/y/width/height can mostly be replaced with getBoundingClientRect(). It is almost identicial, although its behaviour in scrolling areas is different. If performing computations with the values, current code might add on scroll offsets and the like, which probably won't be needed with getBoundingClientRect.

element.boxObject.screenX/screenY can be replaced with element.screenX/screenY.

The property related functions would probably work with just properties on the element. I checked at one point and Thunderbird doesn't use them as far as I can tell anyway.

The element relation properties (at the end of BoxObject.webidl), have no exact equivalent but again I'm not sure if Thunderbird needs them. If so, I can suggest alternatives.

Comment 6

[Jorg K (CEST = GMT+2)]

Thanks, Neil, I filed bug 1535725. Quite a bit to replace:
https://searchfox.org/comm-central/search?q=.boxObject&case=false&regexp=false&path=

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:enndeakin, could you have a look please?

Comment 8

[Neil Deakin]

I was giving Jorg a chance to update for Thunderbird, but perhaps he has no time.

Comment 9

[Jorg K (CEST = GMT+2)]

This looks like a misunderstanding. I was waiting over in bug 1535725 for this to land, and you were waiting for me. Please just land it and we'll deal with it.

Comment 10

[Magnus Melin [:mkmelin]]

Well it does seem better that we'd update the usage first, since it can be done in advance. So if you can hold off for some days please do so.

Comment 11

[Neil Deakin]

I can wait. This bug is relatively low priority.

Comment 12

[Brian Grinstead [:bgrins]]

(In reply to Magnus Melin [:mkmelin] from comment #10)

Well it does seem better that we'd update the usage first, since it can be done in advance. So if you can hold off for some days please do so.

Is this usage removed now?

Comment 13

[Magnus Melin [:mkmelin]]

It is mostly done. There are two more patches in bug 1535725 to take care of the last instances - should be done within a some days.

Comment 14

[Magnus Melin [:mkmelin]]

For Thunderbird, we're now all set.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b4b9f022e10d
remove XUL box objects, r=bzbarsky

Comment 16

[Arthur Iakab [arthur_iakab]]

Backed out changeset b4b9f022e10d (bug 1519948) for causing toolchain build bustage on nsNodeUtils.cpp CLOSED TREE

Backout revision https://hg.mozilla.org/integration/mozilla-inbound/rev/ca9827ffb5a5c09a03401463ff58bec99e059426

Failed push https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=239751330c09bdb7d1ea2ad2cd87685e936c0007

Failure logs https://treeherder.mozilla.org/logviewer.html#?job_id=249423539&repo=mozilla-inbound

Neil can you please take a look?

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b915069eda81
remove XUL box objects, r=bzbarsky

Comment 18

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/b915069eda81