Closed Bug 1519948 Opened 5 years ago Closed 5 years ago

Remove box objects


(Core :: XUL, enhancement, P3)




Tracking Status
firefox69 --- fixed


(Reporter: enndeakin, Assigned: enndeakin)




(2 files)

No description provided.
Depends on: 1519950
Blocks: 1519952
No longer blocks: 1519952
Depends on: 1519952
Depends on: 1519953
Depends on: 1519955
Depends on: 1519956
Depends on: 1519957
Depends on: 1519960
Depends on: 1519967
Assignee: nobody → enndeakin
Depends on: 1530015

Jorg, you may need to deal with this on the comm-central side...

Thanks Boris, can you please give me some details on what to look for or what to replace. Then I'll file a bug with those details.

element.boxObject.x/y/width/height can mostly be replaced with getBoundingClientRect(). It is almost identicial, although its behaviour in scrolling areas is different. If performing computations with the values, current code might add on scroll offsets and the like, which probably won't be needed with getBoundingClientRect.

element.boxObject.screenX/screenY can be replaced with element.screenX/screenY.

The property related functions would probably work with just properties on the element. I checked at one point and Thunderbird doesn't use them as far as I can tell anyway.

The element relation properties (at the end of BoxObject.webidl), have no exact equivalent but again I'm not sure if Thunderbird needs them. If so, I can suggest alternatives.

Depends on: 1535725

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:enndeakin, could you have a look please?

Flags: needinfo?(enndeakin)

I was giving Jorg a chance to update for Thunderbird, but perhaps he has no time.

Flags: needinfo?(enndeakin)

This looks like a misunderstanding. I was waiting over in bug 1535725 for this to land, and you were waiting for me. Please just land it and we'll deal with it.

Well it does seem better that we'd update the usage first, since it can be done in advance. So if you can hold off for some days please do so.

I can wait. This bug is relatively low priority.

(In reply to Magnus Melin [:mkmelin] from comment #10)

Well it does seem better that we'd update the usage first, since it can be done in advance. So if you can hold off for some days please do so.

Is this usage removed now?

Flags: needinfo?(mkmelin+mozilla)

It is mostly done. There are two more patches in bug 1535725 to take care of the last instances - should be done within a some days.

Flags: needinfo?(mkmelin+mozilla)

For Thunderbird, we're now all set.

Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Flags: needinfo?(enndeakin)
You need to log in before you can comment on or make changes to this bug.