Restore two usages of .inset after its removal in bug 1516089

RESOLVED FIXED

Status

enhancement
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

4 months ago

Bug 1516089 removes the styles for .inset and .outset. We use the class inset at two places.

Assignee

Comment 1

4 months ago

Bug 1516089 is on autoland.

The first occurrence is in prefs/Security/Junk "Show log". The border around the log in the dialog.

The second is in Account Settings/Outgoing Server (SMTP) the box below the "Details of selected server:".

Assignee: nobody → richard.marti
Attachment #9036418 - Flags: review?(jorgk)

Comment 2

4 months ago

Comment on attachment 9036418 [details] [diff] [review]
1519965-restore-inset.patch

The change in dialog.css is a little different to what we had, but I'm sure you have your reasons. I didn't try it since I don't have time to rebuild now.

Attachment #9036418 - Flags: review?(jorgk) → review+

Comment 3

4 months ago

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/a08967bc5030
Restore CSS formerly provided by .inset after its removal in bug 1516089. r=jorgk

Status: NEW → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED
Assignee

Comment 4

4 months ago

Yes, the border colour was defined in the removed hunk in aboutPreferences.css. I changed to the variable instead of hard coding it. Also the margin fits better to the margins we use in in-content pages.

You need to log in before you can comment on or make changes to this bug.