1519967 - Change richlistbox to use getBoundingClientRect instead of boxObject

Status: RESOLVED FIXED

(Core :: XUL, enhancement, P3)

Description

[Neil Deakin]

Attachment: Don't use the box object in richlistbox

This patch also replaces some calls to clientHeight with getBoundingClientRect().height which for some reason bug 1472557 changed. I think we should use the original intent here as getBoundingClientRect().height will return the border-box as boxObject.height does whereas clientHeight returns the padding-box.

Comment 1

[:Paolo Amadini]

Comment on attachment 9036416 [details] [diff] [review]
Don't use the box object in richlistbox

Review of attachment 9036416 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/content/widgets/richlistbox.js
@@ +730,5 @@
>      if (!aItem) {
>        return false;
>      }
>  
> +    var y = this.getBoundingClientRect().y;

I guess this.getBoundingClientRect().y == this.scrollTop + this.boxObject.y, so r+ if that's correct.

Again, worth landing after soft code freeze because regressions here might be more difficult to notice.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/75b0a937397c
remove box object computations in richlistbox, r=paolo

Comment 3

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/75b0a937397c