1520144 - “Menu bar” shortcuts can be overridden when assigned for the first time

Status: NEW

(WebExtensions :: Frontend, defect, P3)

Description

[CosminB]

Attachment: Overriden.gif

[Affected versions]:

• Firefox 66.0a1 (20190114215201)

[Affected platforms]:

• Win 7 64-bit
• Ubuntu 14.0.4 32-bit

[Steps to reproduce]:

1. Install https://addons.mozilla.org/en-US/firefox/addon/shortkeys/
2. Navigate to Extensions from about:addons page.
3. Click on the “Keyboard Shortcuts” button.
4. The detailed page with the shortcuts that can be assigned to the extension is displayed.
5. Assign a shortcut key to a command that applies for “Menu Bar”, for example “Alt+F” (Make sure that the “Menu bar” is not visible).
6. Press “Alt+F” and observe.
7. Make the “Menu bar” visible permanently.
8. Press “Alt+F” again.

[Expected results]:

• The user is not allowed to assign commands that Firefox already use.

[Actual results]:

• After Step 6, the assigned “Alt+F” command in the extension shortcuts, is not executed correctly.

[Notes]:

• The same rule applies for: “Alt+E”, “Alt+V”, “Alt+S”, “Alt+B”, “Alt+T”, “Alt+H” or “Shift” + the previous combinations.
• I was not able to reproduce the issue on Mac OS 10.14.1.

Please see the attached video.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Is this bug is still valid? I recall that we added the warning on issues on editing the extension shortcuts and so I was wondering if we do also fixed this issue in another bugzilla issue.

Comment 3

[Shane Caraveo (:mixedpuppy)]

Alex, are you able to reproduce this?

Comment 4

[Alex Cornestean]

Hello Shane,

Following the original STR, I can still reproduce the issue as described using ALT+ the letter combinations mentioned in the Notes section.

SHIFT+ letter combinations don’t work as Firefox explicitly states that the shortcut must include CTRL or ALT. See screenshot.
CTRL+ letter combinations also don’t work as these are already in use by Firefox. See screenshot.

Regarding the particular case of ALT+F:

• after assigning the shortcut, using it will make the Menu Bar visible and open the “File” menu. The add-on function assigned to the shortcut will not execute.
• making the Menu Bar permanently visible causes the shortcut to no longer open the “File” menu but instead execute the add-on function to which it was assigned.
• hiding the Menu Bar again causes the shortcut to execute the add-on function it was assigned to and no longer make the Menu Bar visible / open the “File” menu.
• deleting the shortcut and assigning it again will again cause the behavior from the first bullet point to occur

This is true for all the other ALT+letter combinations.

Tested on the latest Nightly (90.0a1/20210512174859), Beta (89.0b11/20210511190154) and Release (88.0.1/20210504152106) under Windows 10 x64 and Ubuntu 16.04 LTS.

Comment 5

[Alex Cornestean]

Attachment: SHIFT+letter.png

Comment 6

[Alex Cornestean]

Attachment: CTRL+letter.png