UI for re-assigning an extension's command shortcut
Categories
(Toolkit :: Add-ons Manager, enhancement, P2)
Tracking
()
People
(Reporter: bugzilla.mozilla.org, Assigned: mstriemer)
References
(Depends on 2 open bugs, Blocks 4 open bugs)
Details
(Keywords: dev-doc-complete, feature, Whiteboard: [design-decision-approved]triaged [commands])
Attachments
(9 files, 1 obsolete file)
59 bytes,
text/x-review-board-request
|
Details | |
59 bytes,
text/x-review-board-request
|
Details | |
59 bytes,
text/x-review-board-request
|
Details | |
59 bytes,
text/x-review-board-request
|
Details | |
46 bytes,
text/x-phabricator-request
|
aswan
:
review+
|
Details | Review |
46 bytes,
text/x-phabricator-request
|
aswan
:
review+
|
Details | Review |
46 bytes,
text/x-phabricator-request
|
Details | Review | |
46 bytes,
text/x-phabricator-request
|
Details | Review | |
511.42 KB,
image/gif
|
Details |
Updated•8 years ago
|
Updated•8 years ago
|
Comment 2•8 years ago
|
||
Updated•8 years ago
|
Updated•7 years ago
|
Comment hidden (me-too) |
Comment 7•7 years ago
|
||
Comment 8•7 years ago
|
||
Comment 10•7 years ago
|
||
Comment 12•7 years ago
|
||
Comment 13•7 years ago
|
||
Comment 14•7 years ago
|
||
Comment 15•7 years ago
|
||
Comment 16•7 years ago
|
||
Comment 17•7 years ago
|
||
Comment 18•7 years ago
|
||
Assignee | ||
Comment 19•7 years ago
|
||
Comment 20•7 years ago
|
||
Comment 21•7 years ago
|
||
Comment 22•7 years ago
|
||
Comment 23•7 years ago
|
||
Comment 24•7 years ago
|
||
Comment 25•7 years ago
|
||
Comment hidden (offtopic) |
Comment 27•7 years ago
|
||
Comment 28•7 years ago
|
||
Assignee | ||
Comment 29•7 years ago
|
||
Comment 30•7 years ago
|
||
Comment 31•7 years ago
|
||
Comment 33•6 years ago
|
||
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Comment 34•6 years ago
|
||
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 39•6 years ago
|
||
Comment 40•6 years ago
|
||
Assignee | ||
Comment 42•6 years ago
|
||
Assignee | ||
Comment 43•6 years ago
|
||
Assignee | ||
Comment 44•6 years ago
|
||
Comment 45•6 years ago
|
||
Comment 46•6 years ago
|
||
Comment 47•6 years ago
|
||
Updated•6 years ago
|
Assignee | ||
Comment 48•6 years ago
|
||
Assignee | ||
Comment 49•6 years ago
|
||
Comment 50•6 years ago
|
||
Comment 51•6 years ago
|
||
Updated•6 years ago
|
Assignee | ||
Comment 53•6 years ago
|
||
Updated•6 years ago
|
Updated•6 years ago
|
Assignee | ||
Comment 54•6 years ago
|
||
Looks like this is about ready. There were some concerns over non-Latin keyboards in review which look like are okay, but Gijs is looking to do another review tomorrow.
Comment 56•6 years ago
|
||
Comment 57•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f4697feb30df
https://hg.mozilla.org/mozilla-central/rev/d1eacc92d6d6
https://hg.mozilla.org/mozilla-central/rev/456b9b7963eb
https://hg.mozilla.org/mozilla-central/rev/77c0cf8378df
Comment 58•6 years ago
|
||
dev-doc-needed? It would be nice to add this somewhere on the "commands" page.
For reference, you have to go to about:addons -> Extensions -> Keyboard shortcuts (which is a button next to the settings gear).
Wouldn't it be better to move it to a separate tab, to create more visibility?
Comment 59•6 years ago
|
||
you have to go to about:addons -> Extensions -> Keyboard shortcuts
And how to go back?
Comment 60•6 years ago
|
||
(In reply to gwarser from comment #59)
And how to go back?
You just click the "Extensions" item in the left panel again. This is the same as going back to the overview from an extension details/options page.
Comment 61•6 years ago
|
||
When you go to the details page, UI clearly changes and it's like another page, so going back is natural.
Going to shortcuts UI does not change page too much and I expected to have "back" or "toggle" button just under cursor where "Keyboard Shortcuts" button was.
Why not move shortcut UI to the extensions details page?
Comment 62•6 years ago
|
||
The current approach also means that the extension shortcuts page isn't linkable. Compare, e.g., how about:preferences uses fragments like about:preferences#search to identify its different pages.
Comment 63•6 years ago
|
||
(In reply to quasicomputational from comment #62)
The current approach also means that the extension shortcuts page isn't linkable. Compare, e.g., how about:preferences uses fragments like about:preferences#search to identify its different pages.
This isn't due to the current approach, instead it is how the add-on manager behaves in general. None of the add-on manager pages are linkable.
Comment 64•6 years ago
|
||
Updated•6 years ago
|
Comment 65•6 years ago
|
||
bugherder |
Comment 66•6 years ago
|
||
This seems worth a release note in 66 beta.
How about this wording:
WebExtension keyboard shortcuts can now be managed or overridden from about:addons
Comment 67•6 years ago
|
||
(In reply to Liz Henry (:lizzard) (use needinfo) from comment #66)
This seems worth a release note in 66 beta.
How about this wording:
WebExtension keyboard shortcuts can now be managed or overridden from about:addons
Added to Nightly release notes
Comment 68•6 years ago
|
||
Bug:
What happens:
If I try to enter "Ctrl+F4" there (on Linux; German QWERTZ keyboard) it closes the tab of about:addons.
However, when you reopen it, the hotkey is set anyway.
What should happen:
Show this error "cannot overwrite Firefox/Nightly built-in commands" and do not save hotkey.
Comment 69•6 years ago
|
||
Linkable site:
Also I agree with some commenters that it would be great if I could link from my WebExtension to this page, so I can have a button "Customize hotkeys" that takes the user to that site, so they can adjust the hotkey there.
Another feature requests:
IMHO you should list add-ons without any hot keys/commands defined at the bottom of the list. If I, as a user, want to customize the hot keys of an add-on, I do not want to search for it, respectively scroll over 20 add-ons where I cannot even set a hot key, but find it directly, so I am faster and not so much annoyed.
Note:
Also note that some add-ons also show a huge amount of defined hot keys there (https://flagfox.net/viewtopic.php?f=3&t=726), so this may be a little confusing, but I also see no way to dynamically add/request new commands in the WebExtension API, as you always have to pre-define them in your manifest.json.
Comment 70•6 years ago
|
||
If I try to enter "Ctrl+F4" there (on Linux; German QWERTZ keyboard) it closes the tab of about:addons.
Not for me, latest Nightly, installed addon Shortkeys and entering "Alt+F4" for close tab leads to the expected behavior (tab is closed and FF window closure is prevented). Need to inform Peter about that.
Guess this also fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1325692 , although the user enters the shortcut and not the webextension in the example above.
Comment 71•6 years ago
|
||
(In reply to rugk from comment #68)
Bug:
What happens:
If I try to enter "Ctrl+F4" there (on Linux; German QWERTZ keyboard) it closes the tab of about:addons.
However, when you reopen it, the hotkey is set anyway.What should happen:
Show this error "cannot overwrite Firefox/Nightly built-in commands" and do not save hotkey.
This is noted in bug 1520068 which is about exactly the same keyboard input handler.
(In reply to sgl4kn from comment #70)
Not for me, latest Nightly, installed addon Shortkeys and entering "Alt+F4" for close tab leads to the expected behavior (tab is closed and FF window closure is prevented). Need to inform Peter about that.
Ctrl+F4 is something different than Alt+F4 though. Different places where they are handled. My guess would be that this shouldn't be working (i.e. Alt+F4 shouldn't be assignable). I can't assign Alt+F4 (browser closes and shortcut is never saved), so I assume my OS is inserting a stronger handler than yours.
Comment 72•6 years ago
|
||
Ctrl+F4 is something different than Alt+F4 though. Different places where they are handled. My guess would be that this shouldn't be working (i.e. Alt+F4 shouldn't be assignable). I can't assign Alt+F4 (browser closes and shortcut is never saved), so I assume my OS is inserting a stronger handler than yours.
Case in point: Under X11, Alt+F4 is handled by the window manager and the applicaton never receives KeyPress/KeyRelease events for it.
It can usually be rebound in the window manager's hotkey settings. (eg. ~/.config/openbox/... or the "KWin" section of KDE's Global Keyboard Shortcuts control panel... which, in all honesty, I'd been hoping this bug would take design inspiration from in providing a unified, searchable configuration UI for all registered hotkeys, both built-in and extension-defined.)
Comment 73•6 years ago
|
||
(In reply to rugk from comment #69)
Note:
Also note that some add-ons also show a huge amount of defined hot keys there (https://flagfox.net/viewtopic.php?f=3&t=726), so this may be a little confusing, but I also see no way to dynamically add/request new commands in the WebExtension API, as you always have to pre-define them in your manifest.json.
Filed bug 1521389 for this. Please fix this before this new GUI hits release.
Assignee | ||
Updated•6 years ago
|
Comment 75•6 years ago
|
||
Can you please confirm whether this is still targeted for 66?
Comment 77•6 years ago
•
|
||
This issue is verified as fixed on Firefox 66.0-build3 (20190314174725) and Firefox 67.0a1 (20190317213820) under Win 7 64-bit and Mac OS X 10.14.1.
The new UI for assigning shortcut keys in the command field of the extension, is displayed in about:addons.
Please see the attached video.
We can mark this bug verified as fixed since has landed in Fx66, with the mention that the rest of the bugs are considered as future improvements for Fx67, according to Relman.
Comment 78•6 years ago
|
||
Thanks so much for the hard work :D
Comment 79•6 years ago
|
||
Can someone suggest an add-on that I could use to create a screenshot?
Assignee | ||
Comment 80•6 years ago
|
||
You can use Firefox Screenshots (under the ... or scissors button in the address bar) or take one through your operating system.
Assignee | ||
Comment 81•6 years ago
|
||
Actually if you want a screenshot of this feature you'll need to use your operating systems functionality. Looks like screenshots (or any other add-on) isn't supported on about:addons.
Comment 82•6 years ago
|
||
My bad. I wasn't clear about what I was asking for. I was asking for an add-on that would have a shortcut key so I can create a screenshot (I know how to do that part) of the new UI. None of the add-ons I use have shortcut keys. I guess I was so focused on what I wanted that I didn't think about how it could be read.
Comment hidden (obsolete) |
Comment 84•6 years ago
|
||
Depends on how many commands you want to have visible etc., I guess.
If want just one, with a description, you can use my add-on at https://addons.mozilla.org/firefox/addon/offline-qr-code-generator/
This looks like that: https://hostux.pics/images/2019/04/13/image39357b76ed09510a.png
Or, multiple add-ons?
E.g. here is how some things look in my Firefox: https://hostux.pics/images/2019/04/13/imagebd21bccec0627f46.png
Comment 85•6 years ago
|
||
(Sorry for double-posting. Accidentally pressed the submit button too fast.)
Comment 86•6 years ago
|
||
Thanks!
Assignee | ||
Updated•6 years ago
|
Comment 87•5 years ago
|
||
I added a new section at https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/commands#Updating_shortcuts and referenced the video from comment 77.
Comment 88•5 years ago
|
||
Any way to open this UI programmatically from an extension? If not, why? It'd be much more convenient so we can add a button in our extension that opens the customization UI instead of explaining what to click and where or showing a gif. In Chrome we can do chrome.tabs.create({url: 'chrome://extensions/shortcuts'})
Assignee | ||
Comment 89•5 years ago
|
||
That seems like a reasonable API, I don't think we have one right now. This bug shouldn't be used for support requests though, so asking in the matrix chat or filing a new bug would be good.
Description
•