1520163 - nasm 2.13.02 is required to enable dav1d ASM build in OSX

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Alex Chronopoulos [:achronop]]

According to dav1d issue in [1] nasm 2.13.01 contains a bug that will make dav1d crash in OSX.

Also, dav1d developers are planning to update the minimum nasm version to 2.13.02 in their build files (from IRC).

[1] https://code.videolan.org/videolan/dav1d/issues/225

Comment 1

[Gabriele Svelto [:gsvelto]]

This also needed to fix bug 1510698. nasm 2.13.01 contains another bug that generates invalid DWARF debugging information.

Comment 2

[Tyson Smith [:tsmith]]

Any updates? As mentioned in bug 1510698 this is currently blocking fuzzing with debug builds.

Comment 3

[Thomas Daede [:TD-Linux]]

Attachment: Bug 1520163 - Add linux64-nasm toolchain.

Comment 4

[Thomas Daede [:TD-Linux]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=153577056ec81b66fa58a623c2d6a1d991bbbc09

Comment 5

[Thomas Daede [:TD-Linux]]

Attachment: Bug 1520163 - Remove nasm debian package.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Ping - looks like patches are ready to land except for one URL nit?

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e89b6e3d3de8
Add linux64-nasm toolchain. r=glandium

Comment 8

[Thomas Daede [:TD-Linux]]

yup just got r+'d this morning.

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Oh, my bad - for some reason I thought they'd been sitting for a while. I guess I didn't look closely at the timestamps inside phabricator. Sorry for the noise then :/

Comment 10

[Andrei Ciure[:aciure]]

Backed out changeset e89b6e3d3de8 (bug 1520163) for profile-guided optimization builds bustage

push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=e89b6e3d3de81c918b6fb6ed334a642d1f46bef2

failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=d62b974d529cb8a011bc89b8c1693ff1d67d0eb4&selectedJob=229975254&searchStr=linux%2Cx64%2Cpgo%2Cprofile-guided%2Coptimization%2Cbuilds%2Cinstrumented-build-linux64%2Fpgo%2Cbpgo%28instr%29

backout: https://hg.mozilla.org/integration/autoland/rev/4978133d62260c9405d07d049e01bda746dee9af

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e9e880f7aee4
Add linux64-nasm toolchain. r=glandium

Comment 12

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/e9e880f7aee4

Comment 13

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/e9e880f7aee4

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7c4ce602056e
Port bug 1520163 - Add linux64-nasm toolchain to CI. rs=bustage-fix

Comment 15

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/a238fb5cc415
Backed out changeset e9e880f7aee4 for failing nightly builds a=backout

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/53437ed67177
Backed out changeset 7c4ce602056e since M-C part got backed out. a=backout DONTBUILD

Comment 17

[Kartikaya Gupta (email:[e-mail])]

When relanding please make sure the searchfox jobs include the new toolchain, as per the patch on bug 1530115. Presumably your also missing some Android nightly jobs somewhere which is why this got backed out.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fae88bb4c6da
Add linux64-nasm toolchain. r=glandium

Comment 19

[Thomas Daede [:TD-Linux]]

Attachment: Bug 1520163 - Add linux64-nasm to android-armv7-searchfox.

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/575da58a58c7
Add linux64-nasm to android-armv7-searchfox. r=kats

Comment 21

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/fae88bb4c6da
https://hg.mozilla.org/mozilla-central/rev/575da58a58c7

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e1cd169a3f91
Port bug 1520163 - Add linux64-nasm toolchain to CI. rs=bustage-fix

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e06a25b5771c
Remove nasm debian package. r=glandium

Comment 24

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e06a25b5771c

Comment 25

[Peter Van der Beken [:peterv]]

https://hg.mozilla.org/projects/ash/rev/e06a25b5771c1024c6539d2d94fbc011a8cc6884
Bug 1520163 - Remove nasm debian package. r=glandium