Closed Bug 1520163 Opened 10 months ago Closed 9 months ago

nasm 2.13.02 is required to enable dav1d ASM build in OSX

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox67 fixed)

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: achronop, Assigned: TD-Linux)

References

Details

(Whiteboard: [fuzzblocker])

Attachments

(3 files)

According to dav1d issue in [1] nasm 2.13.01 contains a bug that will make dav1d crash in OSX.

Also, dav1d developers are planning to update the minimum nasm version to 2.13.02 in their build files (from IRC).

[1] https://code.videolan.org/videolan/dav1d/issues/225

Blocks: 1521186

This also needed to fix bug 1510698. nasm 2.13.01 contains another bug that generates invalid DWARF debugging information.

Blocks: 1510698

Any updates? As mentioned in bug 1510698 this is currently blocking fuzzing with debug builds.

Whiteboard: [fuzzblocker]
Depends on: 1511224

Ping - looks like patches are ready to land except for one URL nit?

Flags: needinfo?(tdaede)
Pushed by tdaede@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e89b6e3d3de8
Add linux64-nasm toolchain. r=glandium

yup just got r+'d this morning.

Flags: needinfo?(tdaede)

Oh, my bad - for some reason I thought they'd been sitting for a while. I guess I didn't look closely at the timestamps inside phabricator. Sorry for the noise then :/

Pushed by tdaede@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e9e880f7aee4
Add linux64-nasm toolchain. r=glandium
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/7c4ce602056e
Port bug 1520163 - Add linux64-nasm toolchain to CI. rs=bustage-fix
Assignee: nobody → tdaede
Backout by aciure@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/a238fb5cc415
Backed out changeset e9e880f7aee4 for failing nightly builds a=backout
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/53437ed67177
Backed out changeset 7c4ce602056e since M-C part got backed out. a=backout DONTBUILD
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla67 → ---

When relanding please make sure the searchfox jobs include the new toolchain, as per the patch on bug 1530115. Presumably your also missing some Android nightly jobs somewhere which is why this got backed out.

Depends on: 1530289
Pushed by tdaede@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fae88bb4c6da
Add linux64-nasm toolchain. r=glandium
Pushed by tdaede@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/575da58a58c7
Add linux64-nasm to android-armv7-searchfox. r=kats
Status: REOPENED → RESOLVED
Closed: 9 months ago9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/e1cd169a3f91
Port bug 1520163 - Add linux64-nasm toolchain to CI. rs=bustage-fix
Pushed by tdaede@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e06a25b5771c
Remove nasm debian package. r=glandium
Flags: needinfo?(tdaede)
You need to log in before you can comment on or make changes to this bug.