1520224 - There is no autofill suggestions on Firefox beta 65

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, defect, P1)

Description

[Sergey Pronoza]

Steps to reproduce:

1. Navigate to about: config and set extensions.formautofill.available to "on".
2. Open https://luke-chang.github.io/autofill-demo/basic.html
3. Fill fields with some data
4. Press "Submit"

Expected: The autofill warning popup is displayed
Actual: There is no popup showed. The Autofill is not avaliable

Comment 1

[Sayed [:LiquidO2]]

14:53.01 INFO: No more inbound revisions, bisection finished.
14:53.01 INFO: Last good revision: 5313921e7dee83ab65f358b723f4228b46937686
14:53.01 INFO: First bad revision: 29e7b5d5f5e4252ab268e176ee5576f4db146f7a
14:53.01 INFO: Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=5313921e7dee83ab65f358b723f4228b46937686&tochange=29e7b5d5f5e4252ab268e176ee5576f4db146f7a

This seems to be regressed by Bug 1481972

Comment 2

[Matthew N. [:MattN]]

(In reply to Sergey Pronoza from comment #0)

Steps to reproduce:

1. Navigate to about: config and set extensions.formautofill.available to "on".
2. Open https://luke-chang.github.io/autofill-demo/basic.html
3. Fill fields with some data
4. Press "Submit"

Expected: The autofill warning popup is displayed

That's only expected when your submit an address which was autofilled but you modified or this is the first submission for the profile.

Actual: There is no popup showed. The Autofill is not avaliable

You can check if autofill is available if you get the dropdown on the form fields that you have saved data for. Does that work?

Comment 3

[Matthew N. [:MattN]]

Also, after bug 1481972 we only support saving addresses from autofill for the US. There has been a message on the add/edit form in Preferences saying "Form Autofill is currently available only for certain countries." even before that bug.

Comment 4

[Tracy Walker [:tracy]]

This is broken for me in US too. At least with the test page given. I enter values in each field. Then click submit. Then go back to any field, either click in it or begin typing some expected form autocomplete information. The item to autocomplete is not listed. I am kind of wondering if it's the test page? https://www.w3schools.com/html/html_forms.asp seems to work fine.

Comment 5

[Andrew Overholt [:overholt]]

My understanding is we're not going to have another 64 dot release given the impending 65 release.

Comment 6

[Matthew N. [:MattN]]

(In reply to Tracy Walker [:tracy] from comment #4)

This is broken for me in US too. At least with the test page given. I enter values in each field. Then click submit. Then go back to any field, either click in it or begin typing some expected form autocomplete information. The item to autocomplete is not listed.

Was the address you entered one with the country being the U.S. or empty? That's what I'm referring to in comment 3. Also, if you change any region prefs or extensions.formautofill.*available ones you must restart the browser for them to take effect.

I am kind of wondering if it's the test page? https://www.w3schools.com/html/html_forms.asp seems to work fine.

The original test page works fine for me on Beta so I still wonder if the tests are meeting the requirements for autofill.

To be explicit, here are the requirements[1][2] for saving on beta (avoiding step 1 from the comment 0 STR):

• The build must be an en-US one.
• The user must have created the Firefox profile in the U.S. so that the browser.search.region pref is set to "US" and that pref must have been set before the current session started. i.e. if you change that pref you need to restart for it to affect autofill.
• The address being saved must be for the country of the U.S. If no country can be identified or is specified, it will be assumed to be from the U.S.
• The form autofill checkbox in preferences (extensions.formautofill.addresses.enabled) must be on: about:preferences#privacy-form-autofill

To repeat from earlier, you should not expect to see a doorhanger for saving addresses, we only show one upon the first submission in the profile. To check if the address was saved, it's best to look in the "Saved Addresses…" list at about:preferences#privacy-form-autofill

If you think your tests meet all those requirements but you still don't see the address added to Saved Addresses (assuming it is a new address and not already there) then please set the pref extensions.formautofill.loglevel to Debug and restart the browser then try again. Then attach the output of the the Browser Console and the Browser Content Toolbox to this bug along with about:support. A screenshot or screencast showing the address being filled would also be very helpful.

Thanks

[1] https://searchfox.org/mozilla-central/rev/bee8cf15c901b9f4b0c074c9977da4bbebc506e3/browser/extensions/formautofill/api.js#52,55,58-59,64
[2] https://searchfox.org/mozilla-central/rev/c21d6620d384dfb13ede6054015da05a6353b899/browser/extensions/formautofill/FormAutofillHandler.jsm#565

Comment 7

[Tracy Walker [:tracy]]

Matthew, the details are much appreciated. I think it was not working for me because I was inputting random strings, including in the country field. When I enter US for country, the form information is retained after submit.

We'll have to consider the viability of automating this test case. The profile in use for the test is a precanned, made in USA profile. Is it possible to spoof US with configs/prefs even if test machine is outside of USA?

Comment 8

[Matthew N. [:MattN]]

(In reply to Tracy Walker [:tracy] from comment #7)

Matthew, the details are much appreciated. I think it was not working for me because I was inputting random strings, including in the country field. When I enter US for country, the form information is retained after submit.

OK, great to hear. Can we mark the bug as invalid or should I also wait for Sergey to confirm?

We'll have to consider the viability of automating this test case. The profile in use for the test is a precanned, made in USA profile. Is it possible to spoof US with configs/prefs even if test machine is outside of USA?

Yes, you can force the pref browser.search.region to "US" but that has to be set at startup time. That pref also affects the search service so affects which engines are installed.

Comment 9

[Tracy Walker [:tracy]]

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #8)

(In reply to Tracy Walker [:tracy] from comment #7)

Matthew, the details are much appreciated. I think it was not working for me because I was inputting random strings, including in the country field. When I enter US for country, the form information is retained after submit.

OK, great to hear. Can we mark the bug as invalid or should I also wait for Sergey to confirm?

We'll have to consider the viability of automating this test case. The profile in use for the test is a precanned, made in USA profile. Is it possible to spoof US with configs/prefs even if test machine is outside of USA?

Yes, you can force the pref browser.search.region to "US" but that has to be set at startup time. That pref also affects the search service so affects which engines are installed.

Heh, I wish I had known that last little tidbit about the pref affecting search engines. It would have solved a massive headache we worked around.

I think INVALID as well.

Sergey please confirm by setting the pref browser.search.region to "US" in the test case setup method. Then use US as country for that input field.

Comment 10

[Sergey Pronoza]

(In reply to Tracy Walker [:tracy] from comment #9)

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #8)

(In reply to Tracy Walker [:tracy] from comment #7)

Matthew, the details are much appreciated. I think it was not working for me because I was inputting random strings, including in the country field. When I enter US for country, the form information is retained after submit.

OK, great to hear. Can we mark the bug as invalid or should I also wait for Sergey to confirm?

We'll have to consider the viability of automating this test case. The profile in use for the test is a precanned, made in USA profile. Is it possible to spoof US with configs/prefs even if test machine is outside of USA?

Yes, you can force the pref browser.search.region to "US" but that has to be set at startup time. That pref also affects the search service so affects which engines are installed.

Heh, I wish I had known that last little tidbit about the pref affecting search engines. It would have solved a massive headache we worked around.

I think INVALID as well.

Sergey please confirm by setting the pref browser.search.region to "US" in the test case setup method. Then use US as country for that input field.

Bug still reproducible even with changing browser.search.region to "US"

Comment 11

[Matthew N. [:MattN]]

(In reply to Sergey Pronoza from comment #10)

Bug still reproducible even with changing browser.search.region to "US"

Please follow comment 6, specifically the last paragraph.

Comment 12

[Sergey Pronoza]

Attachment: about_support.txt

"about_support" after executing Autofill test

Comment 13

[Sergey Pronoza]

Attachment: the output of the the Browser Console pt.1

The output of the the Browser Console after Autofill test execution

Comment 14

[Sergey Pronoza]

Attachment: The output of the the Browser Console pt.2

The output of the the Browser Console after Autofill test execution

Comment 15

[Sergey Pronoza]

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #11)

(In reply to Sergey Pronoza from comment #10)

Bug still reproducible even with changing browser.search.region to "US"

Please follow comment 6, specifically the last paragraph.

Still not working. The item to autocomplete is not listed. Please see attachment.

Comment 16

[Tracy Walker [:tracy]]

Sergey is right. The form information is saved in latest Firefox Beta 65.0b11, but the data is not presented back in the sample form.

Comment 17

[Matthew N. [:MattN]]

Ok, I think I have some ideas now. Can someone who can repro confirm that this problem doesn't happen in release 64? I think we need to uplift the fix in bug 1515970.

Comment 18

[Matthew N. [:MattN]]

That patch in bug 1515970 fixes it for me. I'll make a try push when the trees re-open. An answer to comment 17 will still be good to ensure there isn't multiple different issues.

Comment 19

[Tracy Walker [:tracy]]

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #18)

That patch in bug 1515970 fixes it for me. I'll make a try push when the trees re-open. An answer to comment 17 will still be good to ensure there isn't multiple different issues.

Works as expected in Fx 64.0.2

and works correctly in latest Nightly as verification of 1515970 indicated.

Comment 20

[Matthew N. [:MattN]]

Thanks. Trees are still closed so I don't have a test build yet.

Comment 21

[Matthew N. [:MattN]]

Can someone please verify the fix with this build (beta + the patch) for macOS: https://queue.taskcluster.net/v1/task/DjZh3n_bRGilIoYbzV_m4Q/runs/0/artifacts/public/build/target.dmg

Comment 22

[Jared Wein [:jaws] (please needinfo? me)]

For comment #21.

Comment 23

[Tracy Walker [:tracy]]

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #21)

Can someone please verify the fix with this build (beta + the patch) for macOS: https://queue.taskcluster.net/v1/task/DjZh3n_bRGilIoYbzV_m4Q/runs/0/artifacts/public/build/target.dmg

Autocomplete does not work with above build using a fresh profile. browser.search.region = US The form was filled using US in the country field.

Comment 24

[Tracy Walker [:tracy]]

(In reply to Tracy Walker [:tracy] from comment #23)

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #21)

Can someone please verify the fix with this build (beta + the patch) for macOS: https://queue.taskcluster.net/v1/task/DjZh3n_bRGilIoYbzV_m4Q/runs/0/artifacts/public/build/target.dmg

Autocomplete does not work with above build using a fresh profile. browser.search.region = US The form was filled using US in the country field.

check that. On restart and retry. Autofill does indeed work with the above build.

Name Firefox
Version 65.0b13
Build ID 20190117232427

Comment 25

[Ryan VanderMeulen [:RyanVM]]

Fixed by bug 1515970.