Closed Bug 1520236 Opened 2 years ago Closed 2 years ago

[css-logical] Implement the border-{block,inline}-{color,style,width} shorthands

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: mats, Assigned: mats)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

Comment on attachment 9036643 [details] [diff] [review]
[css-logical] Implement the border-{block,inline}-{color,style,width} shorthands

Review of attachment 9036643 [details] [diff] [review]:
-----------------------------------------------------------------

If you could annotate the failures in the ini files it'd be amazing, other than that looks good :)
Attachment #9036643 - Flags: review?(emilio) → review+
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/009cf5f885ba
[css-logical] Implement the border-{block,inline}-{color,style,width} shorthands.  r=emilio

(In reply to Emilio Cobos Álvarez (:emilio) from comment #2)

If you could annotate the failures in the ini files it'd be amazing, other
than that looks good :)

Meh, there are probably dozens of these so it doesn't seem worth my time
to annotate them. We should probably just fix bug 1520396 to make
the tests succeed instead, assuming there's consensus about how to
serialize shorthands now.

Mats, you'll want the changes in bug 1520598 comment 6 when relanding. (direct link to that patch: attachment 9037091 [details] [diff] [review])
(feel free to just merge that in with your main patch here; it's a trivial bonus change)

Thanks Daniel. I'll reland with that change...

Flags: needinfo?(mats)
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/47d3dbd969f5
[css-logical] Implement the border-{block,inline}-{color,style,width} shorthands.  r=emilio
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Regressions: 1597273
You need to log in before you can comment on or make changes to this bug.