[css-logical] Implement the border-{block,inline}-{color,style,width} shorthands

RESOLVED FIXED in Firefox 66

Status

()

enhancement
P3
normal
RESOLVED FIXED
4 months ago
2 months ago

People

(Reporter: mats, Assigned: mats)

Tracking

({dev-doc-complete})

Trunk
mozilla66
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(1 attachment)

Comment on attachment 9036643 [details] [diff] [review]
[css-logical] Implement the border-{block,inline}-{color,style,width} shorthands

Review of attachment 9036643 [details] [diff] [review]:
-----------------------------------------------------------------

If you could annotate the failures in the ini files it'd be amazing, other than that looks good :)
Attachment #9036643 - Flags: review?(emilio) → review+

Comment 3

4 months ago
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/009cf5f885ba
[css-logical] Implement the border-{block,inline}-{color,style,width} shorthands.  r=emilio
Assignee

Comment 4

4 months ago

(In reply to Emilio Cobos Álvarez (:emilio) from comment #2)

If you could annotate the failures in the ini files it'd be amazing, other
than that looks good :)

Meh, there are probably dozens of these so it doesn't seem worth my time
to annotate them. We should probably just fix bug 1520396 to make
the tests succeed instead, assuming there's consensus about how to
serialize shorthands now.

Mats, you'll want the changes in bug 1520598 comment 6 when relanding. (direct link to that patch: attachment 9037091 [details] [diff] [review])
(feel free to just merge that in with your main patch here; it's a trivial bonus change)

Assignee

Comment 8

4 months ago

Thanks Daniel. I'll reland with that change...

Flags: needinfo?(mats)

Comment 9

4 months ago
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/47d3dbd969f5
[css-logical] Implement the border-{block,inline}-{color,style,width} shorthands.  r=emilio

Comment 10

4 months ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.