Closed Bug 1520598 Opened 2 years ago Closed 2 years ago

Perma layout/style/test/test_visited_reftests.html | reftest comparison: != logical-box-border-color-visited-link-002.html logical-box-border-color-visited-link-ref.html

Categories

(Core :: CSS Parsing and Computation, defect, P5)

defect

Tracking

()

RESOLVED FIXED

People

(Reporter: intermittent-bug-filer, Unassigned)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Filed by: nerli [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=222270730&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/auggYg2UQ4SVh1F3_H5HfQ/runs/0/artifacts/public/logs/live_backing.log

11:19:33 INFO - TEST-INFO | started process screencapture
11:19:33 INFO - TEST-INFO | screencapture: exit 0
11:19:33 INFO - <snipped 141 output lines - if you need more context, please use SimpleTest.requestCompleteLog() in your test>
11:19:33 INFO - Buffered messages logged at 11:19:21
11:19:33 INFO - TEST-PASS | layout/style/test/test_visited_reftests.html | reftest comparison: == svg-image-visited-1c.html svg-image-visited-1-ref.html
11:19:33 INFO - TEST-PASS | layout/style/test/test_visited_reftests.html | reftest comparison: == svg-image-visited-1d.html svg-image-visited-1-ref.html
11:19:33 INFO - Buffered messages logged at 11:19:22
11:19:33 INFO - TEST-FAIL | layout/style/test/test_visited_reftests.html | The author of the test has indicated that flaky timeouts are expected. Reason: async link coloring
11:19:33 INFO - TEST-FAIL | layout/style/test/test_visited_reftests.html | The author of the test has indicated that flaky timeouts are expected. Reason: async link coloring
11:19:33 INFO - TEST-FAIL | layout/style/test/test_visited_reftests.html | The author of the test has indicated that flaky timeouts are expected. Reason: async link coloring
11:19:33 INFO - TEST-FAIL | layout/style/test/test_visited_reftests.html | The author of the test has indicated that flaky timeouts are expected. Reason: async link coloring
11:19:33 INFO - TEST-FAIL | layout/style/test/test_visited_reftests.html | The author of the test has indicated that flaky timeouts are expected. Reason: async link coloring
11:19:33 INFO - TEST-FAIL | layout/style/test/test_visited_reftests.html | The author of the test has indicated that flaky timeouts are expected. Reason: async link coloring
11:19:33 INFO - TEST-FAIL | layout/style/test/test_visited_reftests.html | The author of the test has indicated that flaky timeouts are expected. Reason: async link coloring
11:19:33 INFO - TEST-FAIL | layout/style/test/test_visited_reftests.html | The author of the test has indicated that flaky timeouts are expected. Reason: async link coloring
11:19:33 INFO - Buffered messages logged at 11:19:23
11:19:33 INFO - TEST-FAIL | layout/style/test/test_visited_reftests.html | The author of the test has indicated that flaky timeouts are expected. Reason: async link coloring
11:19:33 INFO - TEST-FAIL | layout/style/test/test_visited_reftests.html | The author of the test has indicated that flaky timeouts are expected. Reason: async link coloring
11:19:33 INFO - TEST-FAIL | layout/style/test/test_visited_reftests.html | The author of the test has indicated that flaky timeouts are expected. Reason: async link coloring
11:19:33 INFO - TEST-FAIL | layout/style/test/test_visited_reftests.html | The author of the test has indicated that flaky timeouts are expected. Reason: async link coloring
11:19:33 INFO - TEST-FAIL | layout/style/test/test_visited_reftests.html | The author of the test has indicated that flaky timeouts are expected. Reason: async link coloring
11:19:33 INFO - TEST-FAIL | layout/style/test/test_visited_reftests.html | The author of the test has indicated that flaky timeouts are expected. Reason: async link coloring
11:19:33 INFO - TEST-FAIL | layout/style/test/test_visited_reftests.html | The author of the test has indicated that flaky timeouts are expected. Reason: async link coloring
11:19:33 INFO - TEST-FAIL | layout/style/test/test_visited_reftests.html | The author of the test has indicated that flaky timeouts are expected. Reason: async link coloring
11:19:33 INFO - TEST-FAIL | layout/style/test/test_visited_reftests.html | The author of the test has indicated that flaky timeouts are expected. Reason: async link coloring
11:19:33 INFO - Buffered messages logged at 11:19:24
11:19:33 INFO - TEST-FAIL | layout/style/test/test_visited_reftests.html | The author of the test has indicated that flaky timeouts are expected. Reason: async link coloring
11:19:33 INFO - TEST-FAIL | layout/style/test/test_visited_reftests.html | The author of the test has indicated that flaky timeouts are expected. Reason: async link coloring
11:19:33 INFO - TEST-FAIL | layout/style/test/test_visited_reftests.html | The author of the test has indicated that flaky timeouts are expected. Reason: async link coloring
11:19:33 INFO - TEST-FAIL | layout/style/test/test_visited_reftests.html | The author of the test has indicated that flaky timeouts are expected. Reason: async link coloring
11:19:33 INFO - TEST-FAIL | layout/style/test/test_visited_reftests.html | The author of the test has indicated that flaky timeouts are expected. Reason: async link coloring
11:19:33 INFO - TEST-FAIL | layout/style/test/test_visited_reftests.html | The author of the test has indicated that flaky timeouts are expected. Reason: async link coloring

I think we just need to change the "!=" to "==" here:
https://searchfox.org/mozilla-central/source/layout/style/test/test_visited_reftests.html#95-96

The testcase uses "border-block-color" and it seems that it was previously using "!=" simply because we didn't support that property yet. But now we do, as of the cset linked in comment 1.

Mats or emilio, can you confirm/sanity-check this assessment?

Depends on: 1520236
Flags: needinfo?(mats)

That is right.

Flags: needinfo?(mats)

chatted with emilio in #layout -- I'm going to land a s/!=/==/ adjustment with r=him.

Assignee: nobody → dholbert
Status: NEW → ASSIGNED

Ah, I'm too slow - noemi backed out bug 1520236, since this was busting inbound.

I'll just post the patch for reference, and mats probably wants to merge it with his main commit when relanding.

Summary: Intermittent layout/style/test/test_visited_reftests.html | reftest comparison: != logical-box-border-color-visited-link-002.html logical-box-border-color-visited-link-ref.html → Perma layout/style/test/test_visited_reftests.html | reftest comparison: != logical-box-border-color-visited-link-002.html logical-box-border-color-visited-link-ref.html

Here's the bustage fix that I was about to land (just posting for convenience when mats relands the main patch).

Anyway: for now, I think this is FIXED-by-backout (bug 1520236 comment 6).

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Assignee: dholbert → nobody
You need to log in before you can comment on or make changes to this bug.