Closed Bug 1520289 Opened 8 months ago Closed 8 months ago

Replace TCP/TLS/RTP/SAVPF with correct DTLS value

Categories

(Core :: WebRTC: Signaling, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: drno, Assigned: drno)

References

Details

Attachments

(1 file)

Apparently TCP/TLS/RTP/SAVPF never got registered with IANA: https://www.iana.org/assignments/sdp-parameters/sdp-parameters.xhtml#sdp-parameters-2

Instead we need to use TCP/DTLS/RTP/SAVPF (note the DTLS vs TLS). And yes it looks like UDP/TLS/RTP/SAVPF is still the correct value. And so the two will need to be inconsistent.

Priority: -- → P3
Assignee: nobody → drno
Pushed by nohlmeier@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/34476dc321b5
added TCP/DTLS/RTP/SAVPF to SDP parsing. r=bwc
Blocks: 1520550
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66

This fix added handling of TCP/DTLS/RTP/SAVPF but skipped TCP/DTLS/RTP/SAVP

According to https://tools.ietf.org/html/draft-ietf-rtcweb-jsep-25#section-5.1.2, it should be handled as well.

See Also: → 1526733

(In reply to Roman Shpount from comment #5)

This fix added handling of TCP/DTLS/RTP/SAVPF but skipped TCP/DTLS/RTP/SAVP

According to https://tools.ietf.org/html/draft-ietf-rtcweb-jsep-25#section-5.1.2, it should be handled as well.

Thanks. Yes I overlooked that when I tried to fix it. Will be fixed via bug 1526733 soon.

You need to log in before you can comment on or make changes to this bug.