1520289 - Replace TCP/TLS/RTP/SAVPF with correct DTLS value

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, enhancement, P3)

Description

[Nils Ohlmeier [:drno]]

Apparently TCP/TLS/RTP/SAVPF never got registered with IANA: https://www.iana.org/assignments/sdp-parameters/sdp-parameters.xhtml#sdp-parameters-2

Instead we need to use TCP/DTLS/RTP/SAVPF (note the DTLS vs TLS). And yes it looks like UDP/TLS/RTP/SAVPF is still the correct value. And so the two will need to be inconsistent.

Comment 1

[Nils Ohlmeier [:drno]]

Attachment: Bug 1520289: added TCP/DTLS/RTP/SAVPF to SDP parsing. r?bwc

Comment 2

[Nils Ohlmeier [:drno]]

Try run https://treeherder.mozilla.org/#/jobs?repo=try&revision=b7fb9c4c3b3343e3a6f0112907d20b26e98f6150

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34476dc321b5
added TCP/DTLS/RTP/SAVPF to SDP parsing. r=bwc

Comment 4

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/34476dc321b5

Comment 5

[Roman Shpount]

This fix added handling of TCP/DTLS/RTP/SAVPF but skipped TCP/DTLS/RTP/SAVP

According to https://tools.ietf.org/html/draft-ietf-rtcweb-jsep-25#section-5.1.2, it should be handled as well.

Comment 6

[Nils Ohlmeier [:drno]]

(In reply to Roman Shpount from comment #5)

This fix added handling of TCP/DTLS/RTP/SAVPF but skipped TCP/DTLS/RTP/SAVP

According to https://tools.ietf.org/html/draft-ietf-rtcweb-jsep-25#section-5.1.2, it should be handled as well.

Thanks. Yes I overlooked that when I tried to fix it. Will be fixed via bug 1526733 soon.