Closed Bug 1520550 Opened Last year Closed 6 months ago

Remove TCP/TLS/RTP/SAVPF from SDP parsing in Fx 72 or later

Categories

(Core :: WebRTC: Signaling, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: drno, Assigned: ralderete)

References

Details

(Keywords: good-first-bug)

Attachments

(3 files)

In bug 1520289 we added the correct IANA registered parsing for 'TCP/DTLS/RTP/SAVPF' in Fx 66.
See https://www.iana.org/assignments/sdp-parameters/sdp-parameters.xhtml#sdp-parameters-2

Since the 'TCP/TLS/RTP/SAVPF' never got registered with IANA and Firefox never actively send the string out we should remove it from our code as it's only dead code at that point.
https://searchfox.org/mozilla-central/rev/c21d6620d384dfb13ede6054015da05a6353b899/media/webrtc/signaling/src/sdp/SdpMediaSection.h#55

Depends on: 1520289
Keywords: good-first-bug
Priority: -- → P3
Depends on: 1526733

TCP/TLS/RTP/SAVP and TCP/TLS/RTP/SAVPF were never registered with IANA and were
not used by Firefox, so remove them. In the unit tests, replace them with the
registered TCP/DTLS/RTP/SAVPF string.

The array of transport names is defined in terms of the enum for SDP transport
types, so ensure that the two are consistent.

Depends on D35836

This makes the Rust parser's C API consistent with the changes made to sipcc
(i.e., the removal of unregistered transport types).

Depends on D36043

Pushed by nohlmeier@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/eb02f674b776
Remove TCP/TLS/RTP/SAVP and TCP/TLS/RTP/SAVPF from SDP parsing r=mjf
https://hg.mozilla.org/integration/autoland/rev/621c664bf1d2
Remove TCP/TLS/RTP/SAVP and TCP/TLS/RTP/SAVPF from name array r=mjf
https://hg.mozilla.org/integration/autoland/rev/d0d5a57af502
Remove TCP/TLS/RTP/SAVPF from Rust parser r=mjf
Assignee: nobody → ralderete
You need to log in before you can comment on or make changes to this bug.