1520550 - Remove TCP/TLS/RTP/SAVPF from SDP parsing in Fx 72 or later

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, enhancement, P3)

Description

[Nils Ohlmeier [:drno]]

In bug 1520289 we added the correct IANA registered parsing for 'TCP/DTLS/RTP/SAVPF' in Fx 66.
See https://www.iana.org/assignments/sdp-parameters/sdp-parameters.xhtml#sdp-parameters-2

Since the 'TCP/TLS/RTP/SAVPF' never got registered with IANA and Firefox never actively send the string out we should remove it from our code as it's only dead code at that point.
https://searchfox.org/mozilla-central/rev/c21d6620d384dfb13ede6054015da05a6353b899/media/webrtc/signaling/src/sdp/SdpMediaSection.h#55

Comment 1

[Nils Ohlmeier [:drno]]

To update the references, these two lines need to go:
https://searchfox.org/mozilla-central/rev/928742d3ea30e0eb4a8622d260041564d81a8468/media/webrtc/signaling/src/sdp/SdpMediaSection.h#52,56

Comment 2

[Ryan Alderete]

Attachment: Bug 1520550 - Remove TCP/TLS/RTP/SAVP and TCP/TLS/RTP/SAVPF from SDP parsing

TCP/TLS/RTP/SAVP and TCP/TLS/RTP/SAVPF were never registered with IANA and were
not used by Firefox, so remove them. In the unit tests, replace them with the
registered TCP/DTLS/RTP/SAVPF string.

Comment 3

[Nils Ohlmeier [:drno]]

Try run https://treeherder.mozilla.org/#/jobs?repo=try&revision=3d4dc32b99f1bca29f68ef9146dfbeecde2d07e6

Comment 4

[Ryan Alderete]

Attachment: Bug 1520550 - Remove TCP/TLS/RTP/SAVP and TCP/TLS/RTP/SAVPF from name array

The array of transport names is defined in terms of the enum for SDP transport
types, so ensure that the two are consistent.

Depends on D35836

Comment 5

[Ryan Alderete]

Attachment: Bug 1520550 - Remove TCP/TLS/RTP/SAVPF from Rust parser

This makes the Rust parser's C API consistent with the changes made to sipcc
(i.e., the removal of unregistered transport types).

Depends on D36043

Comment 6

[Ryan Alderete]

Updated try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f55bfc9f056bf4343fa06a2b7a4acdea6940580f

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb02f674b776
Remove TCP/TLS/RTP/SAVP and TCP/TLS/RTP/SAVPF from SDP parsing r=mjf
https://hg.mozilla.org/integration/autoland/rev/621c664bf1d2
Remove TCP/TLS/RTP/SAVP and TCP/TLS/RTP/SAVPF from name array r=mjf
https://hg.mozilla.org/integration/autoland/rev/d0d5a57af502
Remove TCP/TLS/RTP/SAVPF from Rust parser r=mjf

Comment 8

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/eb02f674b776
https://hg.mozilla.org/mozilla-central/rev/621c664bf1d2
https://hg.mozilla.org/mozilla-central/rev/d0d5a57af502