Remove TCP/TLS/RTP/SAVPF from SDP parsing in Fx 72 or later
Categories
(Core :: WebRTC: Signaling, enhancement, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: drno, Assigned: ralderete)
References
Details
(Keywords: good-first-bug)
Attachments
(3 files)
In bug 1520289 we added the correct IANA registered parsing for 'TCP/DTLS/RTP/SAVPF' in Fx 66.
See https://www.iana.org/assignments/sdp-parameters/sdp-parameters.xhtml#sdp-parameters-2
Since the 'TCP/TLS/RTP/SAVPF' never got registered with IANA and Firefox never actively send the string out we should remove it from our code as it's only dead code at that point.
https://searchfox.org/mozilla-central/rev/c21d6620d384dfb13ede6054015da05a6353b899/media/webrtc/signaling/src/sdp/SdpMediaSection.h#55
|
Reporter | |
Updated•6 years ago
|
|
|
Reporter | |
Comment 1•6 years ago
|
||
To update the references, these two lines need to go:
https://searchfox.org/mozilla-central/rev/928742d3ea30e0eb4a8622d260041564d81a8468/media/webrtc/signaling/src/sdp/SdpMediaSection.h#52,56
|
Assignee | |
Comment 2•6 years ago
|
||
TCP/TLS/RTP/SAVP and TCP/TLS/RTP/SAVPF were never registered with IANA and were
not used by Firefox, so remove them. In the unit tests, replace them with the
registered TCP/DTLS/RTP/SAVPF string.
|
|
Reporter | |
Comment 3•6 years ago
|
||
|
|
Assignee | |
Comment 4•6 years ago
|
||
The array of transport names is defined in terms of the enum for SDP transport
types, so ensure that the two are consistent.
Depends on D35836
|
|
Assignee | |
Comment 5•6 years ago
|
||
This makes the Rust parser's C API consistent with the changes made to sipcc
(i.e., the removal of unregistered transport types).
Depends on D36043
|
|
Assignee | |
Comment 6•6 years ago
|
||
|
||
Comment 8•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/eb02f674b776
https://hg.mozilla.org/mozilla-central/rev/621c664bf1d2
https://hg.mozilla.org/mozilla-central/rev/d0d5a57af502
|
||
Updated•6 years ago
|
Description
•