Closed
Bug 1520343
Opened 7 years ago
Closed 7 years ago
Pass through events when choosing random addresses for memory allocation
Categories
(Core Graveyard :: Web Replay, defect)
Core Graveyard
Web Replay
Tracking
(firefox66 fixed)
RESOLVED
FIXED
mozilla66
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: bhackett1024, Assigned: bhackett1024)
References
Details
Attachments
(1 file)
|
395 bytes,
patch
|
ehoogeveen
:
review+
|
Details | Diff | Splinter Review |
Bug 1502733 adds some uses of random numbers when allocating blocks of memory for the JS heap. These allocations can occur at non-deterministic points wrt the execution, so to work with web replay thread events should be passed through when computing the random numbers, per the attached patch. (This didn't show up in automated tests because the web replay tests have been turned off for the last couple days due to bug 1513057.)
Attachment #9036761 -
Flags: review?(emanuel.hoogeveen)
|
||
Comment 1•7 years ago
|
||
Comment on attachment 9036761 [details] [diff] [review]
patch
Review of attachment 9036761 [details] [diff] [review]:
-----------------------------------------------------------------
Ah, I didn't consider that. Glad to see the solution is straightforward!
Attachment #9036761 -
Flags: review?(emanuel.hoogeveen) → review+
Pushed by bhackett@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/adb2bf52cba2
Pass through events when choosing random addresses for memory allocation, r=ehoogeveen.
|
||
Comment 3•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
|
||
Updated•5 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•