1513057 - [socket-proc] Land socket process without http part

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P1)

Description

[Kershaw Chang [:kershaw]]

This is about landing socket process without http part to mc.

Comment 1

[Kershaw Chang [:kershaw]]

Attachment: Bug 1513057 - P1: Start the new socket process basics (prefs, full xpcom init, logging, no sandboxing)

Comment 2

[Kershaw Chang [:kershaw]]

Attachment: Bug 1513057 - P2: Setup crash reporter on socket process

This patch is quite straightforward. Just add socket process support.

Comment 3

[Kershaw Chang [:kershaw]]

Attachment: Bug 1513057 - P3: Setup memory reporter on socket process

To setup memory reporter on socket process, this patch modifies the PSocketProcess protocol to implement the same memory reporting functions as the PContent and PGPU protocols.

Comment 4

[Kershaw Chang [:kershaw]]

Attachment: Bug 1513057 - P4: Update online/offline status to socket process

Comment 5

[Kershaw Chang [:kershaw]]

Attachment: Bug 1513057 - P5: Create IPC between content process and socket process

Comment 6

[Kershaw Chang [:kershaw]]

Attachment: Bug 1513057 - P6: Create Background between content process and socket process

Comment 7

[Kershaw Chang [:kershaw]]

Attachment: Bug 1513057 - P7: Setup Gecko profiler on the socket process

Comment 8

[Kershaw Chang [:kershaw]]

Attachment: Bug 1513057 - P8: Report telemetry from socket process to parent process

Comment 9

[Junior [inactive]]

Attachment: Bug 1513057 - P9: socket oepration should wait until socket process launch

Comment 10

[Kershaw Chang [:kershaw]]

Attachment: Bug 1513057 - P1.1: Create a reusable class to pass prefs to child processes

Comment 11

[Kershaw Chang [:kershaw]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ef649d0ee3ffa70599128103165beddc723f293b

Looks good when socket process is enabled.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e94bbb90315
P1: Start the new socket process basics (prefs, full xpcom init, logging, no sandboxing) r=mayhemer,dragana

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c900ac2519f5
P1.1: Create a reusable class to pass prefs to child processes r=dragana

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/edbda5ee5fd5
P2: Setup crash reporter on socket process r=dragana,mayhemer

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a81f83df08d5
P3: Setup memory reporter on socket process r=dragana,mayhemer

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86032a14d26f
P4: Update online/offline status to socket process r=dragana,mayhemer

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/460bbf0849e1
P5: Create IPC between content process and socket process r=dragana,mayhemer

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f648b5f1a7c2
P6: Create Background between content process and socket process r=dragana,mayhemer

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de65c456aad6
P7: Setup Gecko profiler on the socket process r=dragana,mayhemer,mstange

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46411c5de3da
P8: Report telemetry from socket process to parent process r=dragana,mayhemer,janerik

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56329b5f1844
P9: socket oepration should wait until socket process launch r=mayhemer,dragana,kershaw

Comment 22

[Andreea Pavel [:apavel]]

Backed out for build bustages

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=4e94bbb9031517d9953adc24b6ff5646600df028&selectedJob=221325594

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=221325594&repo=autoland&lineNumber=16062

Android bustages push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=edbda5ee5fd53f9ba0ab75477f08c7b29088eca1&selectedJob=221326328

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=221326328&repo=autoland&lineNumber=29490

Backout: https://hg.mozilla.org/integration/autoland/rev/3f76ed638d83ade10f10cfecd2919936335a4aea

Comment 23

[Kershaw Chang [:kershaw]]

(In reply to Andreea Pavel [:apavel] from comment #22)

Backed out for build bustages

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=4e94bbb9031517d9953adc24b6ff5646600df028&selectedJob=221325594

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=221325594&repo=autoland&lineNumber=16062

Android bustages push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=edbda5ee5fd53f9ba0ab75477f08c7b29088eca1&selectedJob=221326328

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=221326328&repo=autoland&lineNumber=29490

Backout: https://hg.mozilla.org/integration/autoland/rev/3f76ed638d83ade10f10cfecd2919936335a4aea

Thanks for the back out.
I've fixed the build issue.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c37adc4de915898f4e12134c491898b25b7a03c2

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c083f11eb58d
P1: Start the new socket process basics (prefs, full xpcom init, logging, no sandboxing) r=mayhemer,dragana

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/696250a73120
P1.1: Create a reusable class to pass prefs to child processes r=dragana

Comment 26

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba234cd89920
P2: Setup crash reporter on socket process r=dragana,mayhemer

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c4eddc3a80d
P3: Setup memory reporter on socket process r=dragana,mayhemer

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca35e0cd0782
P4: Update online/offline status to socket process r=dragana,mayhemer

Comment 29

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b5904e4ffc0c
P5: Create IPC between content process and socket process r=dragana,mayhemer

Comment 30

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b73660fb915
P6: Create Background between content process and socket process r=dragana,mayhemer

Comment 31

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c65c63971388
P7: Setup Gecko profiler on the socket process r=dragana,mayhemer,mstange

Comment 32

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4af076789478
P8: Report telemetry from socket process to parent process r=dragana,mayhemer,janerik

Comment 33

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d5da954d4dd2
P9: socket oepration should wait until socket process launch r=mayhemer,dragana,kershaw

Comment 34

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/c083f11eb58d
https://hg.mozilla.org/mozilla-central/rev/696250a73120
https://hg.mozilla.org/mozilla-central/rev/ba234cd89920
https://hg.mozilla.org/mozilla-central/rev/7c4eddc3a80d
https://hg.mozilla.org/mozilla-central/rev/ca35e0cd0782
https://hg.mozilla.org/mozilla-central/rev/b5904e4ffc0c
https://hg.mozilla.org/mozilla-central/rev/5b73660fb915
https://hg.mozilla.org/mozilla-central/rev/c65c63971388
https://hg.mozilla.org/mozilla-central/rev/4af076789478
https://hg.mozilla.org/mozilla-central/rev/d5da954d4dd2

Comment 35

[Bogdan Tara[:bogdan_tara | bogdant]]

Landing P1.1 seems to have introduced a perma failure:

https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=92a30f1b817cba3154156a74bee123fc1af7b647&searchStr=os%2Cx%2C10.10%2Copt%2Cmochitests%2Cwith%2Ce10s%2Ctest-macosx64%2Fopt-mochitest-devtools-chrome-e10s-5%2Cm-e10s%28dt5%29&tochange=b5904e4ffc0ca4bdab4084a92176c6a70f93f01c

kershaw, can you, please, take a look?

Comment 36

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/07acdca43a9b
Disable failing web replay tests.

Comment 37

[Brian Hackett [Laid off!]]

I just pushed 07acdca43a9b to disable the web replay tests until I'm able to update web replay so that it works with this change (later today, probably).

Going forward, I'd like to disable these tests when they start failing instead of backing out other changes, to avoid impeding development in the rest of Gecko. After bug 1517837 lands it will be a one line change to disable all of these tests.

Comment 38

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/07acdca43a9b