1520367 - Accounts API: mark special folders with their type

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, enhancement)

Description

[Geoff Lankow (:darktrojan)]

We should have a field on some special types of folders (junk, trash, outbox, etc.) which says what type of folder they are, so they can be identified easily.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1520367-webext-folder-type-1.diff

Comment 2

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 9036840 [details] [diff] [review]
1520367-webext-folder-type-1.diff

Review of attachment 9036840 [details] [diff] [review]:
-----------------------------------------------------------------

Stealing the review. One minor comment to consider:

::: mail/components/extensions/schemas/accounts.json
@@ +42,5 @@
> +          "type": {
> +            "type": "string",
> +            "optional": true,
> +            "description": "The type of folder, for several common types.",
> +            "enum": ["inbox", "drafts", "sent", "trash", "templates", "archives", "junk", "outbox"]

If you look at other API schemas, they tend to define a type and then $ref it. See for example https://searchfox.org/comm-central/source/mail/components/extensions/schemas/windows.json#11

It is possible this only happens when it is actually used more than once, I haven't verified this.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/23ef8a434c94
Accounts API: mark special folders with their type; r=Fallen DONTBUILD

Comment 4

[Geoff Lankow (:darktrojan)]

I discovered one place where this breaks things because the schema asks for an object, not a MailFolder. Will post a patch shortly.

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: 1520367-followup-1.diff

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/21ddeb46254b
followup - Change mailTabs schema to use defined type; r=Fallen