1520369 - Remove more dead code in subconfigure.py

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1520369 - Remove subconfigure cache clearing.

The code only actually handles autoconf 2.5 cache, and was useful when
we have such subconfigures, that would die when things changed in ways
that would make the subconfigure abort on its own. But we have no such
things left, and while we may want to clear the cache for old-configure
(for e.g. bug 1520232), this is not helping to get there.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1520369 - Remove --no-create.

It actually does nothing anymore.

Depends on D16636

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1520369 - Don't remove --srcdir from subconfigure command line.

It was manually removed because autoconf's AC_OUTPUT_SUBDIRS passes it,
but we've not been using AC_OUTPUT_SUBDIRS for a while.

Depends on D16637

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9873a5e507a8
Remove subconfigure cache clearing. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/eda1a7d5a7e9
Remove --no-create. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/99c3cc0b39bd
Don't remove --srcdir from subconfigure command line. r=froydnj

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/9873a5e507a8
https://hg.mozilla.org/mozilla-central/rev/eda1a7d5a7e9
https://hg.mozilla.org/mozilla-central/rev/99c3cc0b39bd